Page MenuHomePhabricator

Skeleton for "Multimeter", a performance sampling application
ClosedPublic

Authored by epriestley on Apr 30 2015, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 1:56 PM
Unknown Object (File)
Fri, Dec 13, 10:10 PM
Unknown Object (File)
Mon, Dec 9, 6:50 AM
Unknown Object (File)
Mon, Dec 9, 6:50 AM
Unknown Object (File)
Mon, Dec 9, 6:50 AM
Unknown Object (File)
Mon, Dec 9, 3:32 AM
Unknown Object (File)
Wed, Dec 4, 9:33 AM
Unknown Object (File)
Wed, Nov 20, 7:14 PM
Subscribers
Tokens
"Like" token, awarded by joshuaspence.

Details

Summary

Ref T6930. This application collects and displays performance samples -- roughly, things Phabricator spent some kind of resource on. It will collect samples on different types of resources and events:

  • Wall time (queries, service calls, pages)
  • Bytes In / Bytes Out (requests)
  • Implicit requests to CSS/JS (static resources)

I've started with the simplest case (static resources), since this can be used in an immediate, straghtforward way to improve packaging (look at which individual files have the most requests recently).

There's no aggregation yet and a lot of the data isn't collected properly. Future diffs will add more dimension data (controllers, users), more event and resource types (queries, service calls, wall time), and more display options (aggregation, sorting).

Test Plan

Screen Shot 2015-04-30 at 8.03.32 AM.png (1×1 px, 465 KB)

Diff Detail

Repository
rP Phabricator
Branch
mm1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5610
Build 5629: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Skeleton for "Multimeter", a performance sampling application.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/aphront/configuration/AphrontApplicationConfiguration.php
62

Maybe a constant down the road?

src/applications/multimeter/controller/MultimeterController.php
31–34

I was worried about this, but I guess practically speaking $rows is only going to be 100ish for this tool so whatevs.

This revision is now accepted and ready to land.Apr 30 2015, 7:03 PM
This revision was automatically updated to reflect the committed changes.