Page MenuHomePhabricator
Differential D12606

`pht` all the things
ClosedPublic
Actions

Authored by joshuaspence on Apr 29 2015, 12:58 PM.
Tags
None
Referenced Files
F14087334: D12606.diff
Sat, Nov 23, 8:59 PM
Unknown Object (File)
Fri, Nov 22, 10:12 AM
Unknown Object (File)
Mon, Nov 18, 7:22 AM
Unknown Object (File)
Fri, Nov 15, 8:51 AM
Unknown Object (File)
Thu, Nov 14, 1:47 AM
Unknown Object (File)
Sun, Nov 10, 4:01 AM
Unknown Object (File)
Wed, Nov 6, 3:44 AM
Unknown Object (File)
Fri, Nov 1, 1:36 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU13899e4637d3: `pht` all the things
Summary

phtize basically all of the strings in rPHU.

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:149XHP45PHP Compatibility
Errorsrc/utils/utils.php:1089XHP45PHP Compatibility
Errorsrc/utils/utils.php:1089XHP45PHP Compatibility
Unit
Test Failures
Build Status
Buildable 5935
Build 5955: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30270.Apr 29 2015, 12:58 PM
joshuaspence retitled this revision from to `pht` all the things.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2015, 12:58 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 29 2015, 1:29 PM
epriestley edited edge metadata.

I suspect we may make some calls to functions in, e.g., utils.php before we install pht(), but since all the translated strings are on error pathways which we "should" never hit this still seems like the correct way forward on the balance.

There's a similar peril where pht() errors, and we call some function in error handling which calls pht() again, looping. However, we "should" never fail in handling an error. One possible inline about this.

(The number of library startup issues we've hit historically is about 0, so it would have to increase tremendously for me to have any real concerns about making them slightly more difficult to debug.)

src/error/PhutilErrorHandler.php
417–420

Because this is specifically a reentry check, and one way we might end up here is by looping on an error in pht(), maybe this string is worth leaving untranslated. The concern is:

pht -> error -> error handler -> some second error -> error handler -> ...

Before the patch that leads to:

... -> clean abort

Now it would lead to:

... -> pht -> error -> ...

However, this also requires a peculiar conflux of circumstances.

This revision is now accepted and ready to land.Apr 29 2015, 1:29 PM
joshuaspence updated this revision to Diff 30549.May 5 2015, 12:13 PM
joshuaspence marked an inline comment as done.
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 30805.May 12 2015, 9:33 PM

Minor tweaks

Closed by commit rPHU13899e4637d3: `pht` all the things (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 12 2015, 11:48 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 138 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
9 lines
aphront/
storage/
connection/
4 lines
39 lines
9 lines
mysql/
13 lines
17 lines
18 lines
exception/
2 lines
writeguard/
56 lines
auth/
11 lines
6 lines
2 lines
11 lines
6 lines
4 lines
cache/
20 lines
6 lines
10 lines
15 lines
__tests__/
2 lines
channel/
7 lines
9 lines
4 lines
2 lines
2 lines
4 lines
__tests__/
2 lines
6 lines
conduit/
22 lines
console/
7 lines
2 lines
5 lines
10 lines
daemon/
9 lines
9 lines
17 lines
torture/
5 lines
error/
2 lines
2 lines
__tests__/
2 lines
filesystem/
9 lines
81 lines
4 lines
2 lines
6 lines
2 lines
7 lines
__tests__/
18 lines
8 lines
2 lines
linesofalarge/
3 lines
8 lines
4 lines
__tests__/
6 lines
12 lines
future/
2 lines
2 lines
2 lines
asana/
15 lines
aws/
6 lines
10 lines
exec/
2 lines
20 lines
6 lines
http/
10 lines
17 lines
34 lines
status/
38 lines
4 lines
6 lines
17 lines
oauth/
23 lines
paypal/
6 lines
twitch/
6 lines
wordpress/
4 lines
grammar/
4 lines
internationalization/
3 lines
4 lines
__tests__/
2 lines
6 lines
ip/
5 lines
5 lines
lexer/
81 lines
__tests__/
2 lines
2 lines
markup/
__tests__/
2 lines
engine/
4 lines
__tests__/
4 lines
remarkup/
blockrule/
10 lines
19 lines
syntax/
engine/
__tests__/
5 lines
highlighter/
__tests__/
6 lines
moduleutils/
24 lines
13 lines
40 lines
object/
8 lines
parser/
111 lines
2 lines
2 lines
__tests__/
2 lines
2 lines
2 lines
2 lines
12 lines
argument/
111 lines
40 lines
__tests__/
4 lines
workflow/
2 lines
4 lines
xhpast/
__tests__/
3 lines
api/
5 lines
bin/
4 lines
phage/
agent/
2 lines
bootloader/
2 lines
util/
5 lines
sprites/
2 lines
28 lines
symbols/
16 lines
exception/
17 lines
utils/
25 lines
4 lines
6 lines
13 lines
20 lines
__tests__/
16 lines
14 lines
24 lines
6 lines
43 lines
29 lines
2 lines
xsprintf/
2 lines
__tests__/
2 lines
4 lines
exception/
2 lines
9 lines
19 lines
3 lines

Diff 30805

View Options

src/__phutil_library_init__.php

View Options

src/aphront/storage/connection/AphrontDatabaseConnection.php

View Options

src/aphront/storage/connection/AphrontDatabaseTransactionState.php

View Options

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

View Options

src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

View Options

src/aphront/storage/exception/AphrontParameterQueryException.php

View Options

src/aphront/writeguard/AphrontWriteGuard.php

View Options

src/auth/PhutilGoogleAuthAdapter.php

View Options

src/auth/PhutilJIRAAuthAdapter.php

View Options

src/auth/PhutilLDAPAuthAdapter.php

View Options

src/auth/PhutilOAuth1AuthAdapter.php

View Options

src/auth/PhutilOAuthAuthAdapter.php

View Options

src/auth/PhutilPersonaAuthAdapter.php

View Options

src/cache/PhutilDirectoryKeyValueCache.php

View Options

src/cache/PhutilKeyValueCacheNamespace.php

View Options

src/cache/PhutilMemcacheKeyValueCache.php

View Options

src/cache/PhutilOnDiskKeyValueCache.php

View Options

src/cache/__tests__/PhutilKeyValueCacheTestCase.php

View Options

src/channel/PhutilChannel.php

View Options

src/channel/PhutilChannelChannel.php

View Options

src/channel/PhutilExecChannel.php

View Options

src/channel/PhutilPHPObjectProtocolChannel.php

View Options

src/channel/PhutilProtocolChannel.php

View Options

src/channel/PhutilSocketChannel.php

View Options

src/channel/__tests__/PhutilJSONProtocolChannelTestCase.php

View Options

src/channel/__tests__/PhutilPHPObjectProtocolChannelTestCase.php

View Options

src/conduit/ConduitClient.php

View Options

src/console/PhutilConsole.php

View Options

src/console/PhutilConsoleProgressBar.php

View Options

src/console/PhutilConsoleStdinNotInteractiveException.php

View Options

src/console/PhutilInteractiveEditor.php

View Options

src/daemon/PhutilDaemon.php

View Options

src/daemon/PhutilDaemonHandle.php

View Options

src/daemon/PhutilDaemonOverseer.php

View Options

src/daemon/torture/PhutilHighIntensityIntervalDaemon.php

View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/error/PhutilOpaqueEnvelope.php

View Options

src/error/__tests__/PhutilErrorHandlerTestCase.php

View Options

src/filesystem/FileFinder.php

View Options

src/filesystem/Filesystem.php

View Options

src/filesystem/PhutilDeferredLog.php

View Options

src/filesystem/PhutilDirectoryFixture.php

View Options

src/filesystem/PhutilFileLock.php

View Options

src/filesystem/PhutilFileTree.php

View Options

src/filesystem/PhutilLock.php

View Options

src/filesystem/__tests__/FileFinderTestCase.php

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

View Options

src/filesystem/__tests__/PhutilFileLockTestCase.php

View Options

src/filesystem/linesofalarge/LinesOfALarge.php

View Options

src/filesystem/linesofalarge/LinesOfALargeExecFuture.php

View Options

src/filesystem/linesofalarge/LinesOfALargeFile.php

View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeExecFutureTestCase.php

View Options

src/filesystem/linesofalarge/__tests__/LinesOfALargeFileTestCase.php

View Options

src/future/Future.php

View Options

src/future/FutureIterator.php

View Options

src/future/FutureProxy.php

View Options

src/future/asana/PhutilAsanaFuture.php

View Options

src/future/aws/PhutilAWSException.php

View Options

src/future/aws/PhutilAWSFuture.php

View Options

src/future/exec/CommandException.php

View Options

src/future/exec/ExecFuture.php

View Options

src/future/exec/PhutilExecPassthru.php

View Options

src/future/http/BaseHTTPFuture.php

View Options

src/future/http/HTTPFuture.php

View Options

src/future/http/HTTPSFuture.php

View Options

src/future/http/status/HTTPFutureCURLResponseStatus.php

View Options

src/future/http/status/HTTPFutureCertificateResponseStatus.php

View Options

src/future/http/status/HTTPFutureParseResponseStatus.php

View Options

src/future/http/status/HTTPFutureTransportResponseStatus.php

View Options

src/future/oauth/PhutilOAuth1Future.php

View Options

src/future/paypal/PhutilPayPalAPIFuture.php

View Options

src/future/twitch/PhutilTwitchFuture.php

View Options

src/future/wordpress/PhutilWordPressFuture.php

View Options

src/grammar/PhutilContextFreeGrammar.php

View Options

src/internationalization/PhutilLocale.php

View Options

src/internationalization/PhutilTranslator.php

View Options

src/internationalization/__tests__/PhutilPersonTest.php

View Options

src/internationalization/__tests__/PhutilTranslatorTestCase.php

View Options

src/ip/PhutilCIDRBlock.php

View Options

src/ip/PhutilIPAddress.php

View Options

src/lexer/PhutilLexer.php

View Options

src/lexer/__tests__/PhutilPHPFragmentLexerTestCase.php

View Options

src/lexer/__tests__/PhutilShellLexerTestCase.php

View Options

src/markup/__tests__/PhutilSafeHTMLTestCase.php

View Options

src/markup/engine/PhutilRemarkupEngine.php

View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupTableBlockRule.php

View Options

src/markup/render.php

View Options

src/markup/syntax/engine/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php

View Options

src/markup/syntax/highlighter/__tests__/PhutilXHPASTSyntaxHighlighterTestCase.php

View Options

src/moduleutils/PhutilBootloader.php

View Options

src/moduleutils/PhutilLibraryConflictException.php

View Options

src/moduleutils/PhutilLibraryMapBuilder.php

View Options

src/object/Phobject.php

View Options

src/parser/PhutilParserGenerator.php

View Options

src/parser/PhutilSimpleOptions.php

View Options

src/parser/PhutilTypeSpec.php

View Options

src/parser/__tests__/PhutilDocblockParserTestCase.php

View Options

src/parser/__tests__/PhutilJSONTestCase.php

View Options

src/parser/__tests__/PhutilLanguageGuesserTestCase.php

View Options

src/parser/__tests__/PhutilParserGeneratorTestCase.php

View Options

src/parser/__tests__/PhutilSimpleOptionsTestCase.php

View Options

src/parser/argument/PhutilArgumentParser.php

View Options

src/parser/argument/PhutilArgumentSpecification.php

View Options

src/parser/argument/__tests__/PhutilArgumentSpecificationTestCase.php

View Options

src/parser/argument/workflow/PhutilArgumentWorkflow.php

View Options

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

View Options

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

View Options

src/parser/xhpast/api/XHPASTTree.php

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

src/phage/agent/PhagePHPAgent.php

View Options

src/phage/bootloader/PhagePHPAgentBootloader.php

View Options

src/phage/util/PhutilBallOfPHP.php

View Options

src/sprites/PhutilSprite.php

View Options

src/sprites/PhutilSpriteSheet.php

View Options

src/symbols/PhutilSymbolLoader.php

View Options

src/symbols/exception/PhutilMissingSymbolException.php

View Options

src/utils/AbstractDirectedGraph.php

View Options

src/utils/PhutilCallbackFilterIterator.php

View Options

src/utils/PhutilDirectedScalarGraph.php

View Options

src/utils/PhutilEditDistanceMatrix.php

View Options

src/utils/PhutilSystem.php

View Options

src/utils/__tests__/AbstractDirectedGraphTestCase.php

View Options

src/utils/__tests__/PhutilEditDistanceMatrixTestCase.php

View Options

src/utils/__tests__/PhutilUTF8TestCase.php

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

View Options

src/utils/utf8.php

View Options

src/utils/utils.php

View Options

src/utils/viewutils.php

View Options

src/xsprintf/PhutilCommandString.php

View Options

src/xsprintf/__tests__/PhutilCsprintfTestCase.php

View Options

src/xsprintf/csprintf.php

View Options

src/xsprintf/exception/XsprintfUnknownConversionException.php

View Options

src/xsprintf/jsprintf.php

View Options

src/xsprintf/qsprintf.php

View Options

src/xsprintf/queryfx.php

Phabricator · Built by Phacility