Paths

Table of Contentst

Differential D12606

`pht` all the things
ClosedPublic
Actions

Authored by joshuaspence on Apr 29 2015, 12:58 PM.

Tags

None

Referenced Files

	F13167304: D12606.diff
	Tue, May 7, 7:03 AM

	Unknown Object (File)
	Fri, May 3, 5:06 AM

	Unknown Object (File)
	Wed, May 1, 7:36 PM

	Unknown Object (File)
	Thu, Apr 25, 12:45 AM

	Unknown Object (File)
	Thu, Apr 11, 9:47 AM

	Unknown Object (File)
	Apr 5 2024, 12:58 PM

	Unknown Object (File)
	Apr 2 2024, 6:10 AM

	Unknown Object (File)
	Mar 31 2024, 11:25 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU13899e4637d3: `pht` all the things

Summary

phtize basically all of the strings in rPHU.

Test Plan

¯\_(ツ)_/¯

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30270.Apr 29 2015, 12:58 PM

joshuaspence retitled this revision from to `pht` all the things.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 29 2015, 12:58 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I suspect we may make some calls to functions in, e.g., utils.php before we install pht(), but since all the translated strings are on error pathways which we "should" never hit this still seems like the correct way forward on the balance.

There's a similar peril where pht() errors, and we call some function in error handling which calls pht() again, looping. However, we "should" never fail in handling an error. One possible inline about this.

(The number of library startup issues we've hit historically is about 0, so it would have to increase tremendously for me to have any real concerns about making them slightly more difficult to debug.)

src/error/PhutilErrorHandler.php
417–420	Because this is specifically a reentry check, and one way we might end up here is by looping on an error in pht(), maybe this string is worth leaving untranslated. The concern is: pht -> error -> error handler -> some second error -> error handler -> ... Before the patch that leads to: ... -> clean abort Now it would lead to: ... -> pht -> error -> ... However, this also requires a peculiar conflux of circumstances.

This revision is now accepted and ready to land.Apr 29 2015, 1:29 PM

Rebase

Minor tweaks

Closed by commit rPHU13899e4637d3: `pht` all the things (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 12 2015, 11:48 PM

This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 138 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_init__.php

9 lines

aphront/

storage/

connection/

AphrontDatabaseConnection.php

4 lines

AphrontDatabaseTransactionState.php

39 lines

AphrontIsolatedDatabaseConnection.php

9 lines

mysql/

AphrontBaseMySQLDatabaseConnection.php

13 lines

AphrontMySQLDatabaseConnection.php

17 lines

AphrontMySQLiDatabaseConnection.php

18 lines

exception/

AphrontParameterQueryException.php

2 lines

writeguard/

AphrontWriteGuard.php

56 lines

auth/

PhutilGoogleAuthAdapter.php

11 lines

PhutilJIRAAuthAdapter.php

6 lines

PhutilLDAPAuthAdapter.php

2 lines

PhutilOAuth1AuthAdapter.php

11 lines

PhutilOAuthAuthAdapter.php

6 lines

PhutilPersonaAuthAdapter.php

4 lines

cache/

PhutilDirectoryKeyValueCache.php

20 lines

PhutilKeyValueCacheNamespace.php

6 lines

PhutilMemcacheKeyValueCache.php

10 lines

PhutilOnDiskKeyValueCache.php

15 lines

__tests__/

PhutilKeyValueCacheTestCase.php

2 lines

channel/

PhutilChannel.php

7 lines

PhutilChannelChannel.php

9 lines

PhutilExecChannel.php

4 lines

PhutilPHPObjectProtocolChannel.php

2 lines

PhutilProtocolChannel.php

2 lines

PhutilSocketChannel.php

4 lines

__tests__/

PhutilJSONProtocolChannelTestCase.php

2 lines

PhutilPHPObjectProtocolChannelTestCase.php

6 lines

conduit/

ConduitClient.php

22 lines

console/

PhutilConsole.php

7 lines

PhutilConsoleProgressBar.php

2 lines

PhutilConsoleStdinNotInteractiveException.php

5 lines

PhutilInteractiveEditor.php

10 lines

daemon/

PhutilDaemon.php

9 lines

PhutilDaemonHandle.php

9 lines

PhutilDaemonOverseer.php

17 lines

torture/

PhutilHighIntensityIntervalDaemon.php

5 lines

error/

PhutilErrorHandler.php

2 lines

PhutilOpaqueEnvelope.php

2 lines

__tests__/

PhutilErrorHandlerTestCase.php

2 lines

filesystem/

9 lines

81 lines

PhutilDeferredLog.php

4 lines

PhutilDirectoryFixture.php

2 lines

PhutilFileLock.php

6 lines

PhutilFileTree.php

2 lines

7 lines

__tests__/

FileFinderTestCase.php

18 lines

PhutilDeferredLogTestCase.php

8 lines

PhutilFileLockTestCase.php

2 lines

linesofalarge/

LinesOfALarge.php

3 lines

LinesOfALargeExecFuture.php

8 lines

LinesOfALargeFile.php

4 lines

__tests__/

LinesOfALargeExecFutureTestCase.php

6 lines

LinesOfALargeFileTestCase.php

12 lines

future/

2 lines

FutureIterator.php

2 lines

FutureProxy.php

2 lines

asana/

PhutilAsanaFuture.php

15 lines

aws/

PhutilAWSException.php

6 lines

PhutilAWSFuture.php

10 lines

exec/

CommandException.php

2 lines

20 lines

PhutilExecPassthru.php

6 lines

http/

BaseHTTPFuture.php

10 lines

17 lines

HTTPSFuture.php

34 lines

status/

HTTPFutureCURLResponseStatus.php

38 lines

HTTPFutureCertificateResponseStatus.php

4 lines

HTTPFutureParseResponseStatus.php

6 lines

HTTPFutureTransportResponseStatus.php

17 lines

oauth/

PhutilOAuth1Future.php

23 lines

paypal/

PhutilPayPalAPIFuture.php

6 lines

twitch/

PhutilTwitchFuture.php

6 lines

wordpress/

PhutilWordPressFuture.php

4 lines

grammar/

PhutilContextFreeGrammar.php

4 lines

internationalization/

PhutilLocale.php

3 lines

PhutilTranslator.php

4 lines

__tests__/

PhutilPersonTest.php

2 lines

PhutilTranslatorTestCase.php

6 lines

ip/

PhutilCIDRBlock.php

5 lines

PhutilIPAddress.php

5 lines

lexer/

PhutilLexer.php

81 lines

__tests__/

PhutilPHPFragmentLexerTestCase.php

2 lines

PhutilShellLexerTestCase.php

2 lines

markup/

__tests__/

PhutilSafeHTMLTestCase.php

2 lines

engine/

PhutilRemarkupEngine.php

4 lines

__tests__/

PhutilRemarkupEngineTestCase.php

4 lines

remarkup/

blockrule/

PhutilRemarkupTableBlockRule.php

10 lines

19 lines

syntax/

engine/

__tests__/

PhutilDefaultSyntaxHighlighterEngineTestCase.php

5 lines

highlighter/

__tests__/

PhutilXHPASTSyntaxHighlighterTestCase.php

6 lines

moduleutils/

PhutilBootloader.php

24 lines

PhutilLibraryConflictException.php

13 lines

PhutilLibraryMapBuilder.php

40 lines

object/

8 lines

parser/

PhutilParserGenerator.php

111 lines

PhutilSimpleOptions.php

2 lines

PhutilTypeSpec.php

2 lines

__tests__/

PhutilDocblockParserTestCase.php

2 lines

PhutilJSONTestCase.php

2 lines

PhutilLanguageGuesserTestCase.php

2 lines

PhutilParserGeneratorTestCase.php

2 lines

PhutilSimpleOptionsTestCase.php

12 lines

argument/

PhutilArgumentParser.php

111 lines

PhutilArgumentSpecification.php

40 lines

__tests__/

PhutilArgumentSpecificationTestCase.php

4 lines

workflow/

PhutilArgumentWorkflow.php

2 lines

PhutilHelpArgumentWorkflow.php

4 lines

xhpast/

__tests__/

PHPASTParserTestCase.php

3 lines

api/

5 lines

bin/

PhutilXHPASTBinary.php

4 lines

phage/

agent/

PhagePHPAgent.php

2 lines

bootloader/

PhagePHPAgentBootloader.php

2 lines

util/

PhutilBallOfPHP.php

5 lines

sprites/

PhutilSprite.php

2 lines

PhutilSpriteSheet.php

28 lines

symbols/

PhutilSymbolLoader.php

16 lines

exception/

PhutilMissingSymbolException.php

17 lines

utils/

AbstractDirectedGraph.php

25 lines

PhutilCallbackFilterIterator.php

4 lines

PhutilDirectedScalarGraph.php

6 lines

PhutilEditDistanceMatrix.php

13 lines

PhutilSystem.php

20 lines

__tests__/

AbstractDirectedGraphTestCase.php

16 lines

PhutilEditDistanceMatrixTestCase.php

14 lines

PhutilUTF8TestCase.php

24 lines

PhutilUtilsTestCase.php

6 lines

43 lines

29 lines

2 lines

xsprintf/

PhutilCommandString.php

2 lines

__tests__/

PhutilCsprintfTestCase.php

2 lines

4 lines

exception/

XsprintfUnknownConversionException.php

2 lines

9 lines

19 lines

3 lines

Diff 30810

src/__phutil_library_init__.php

src/aphront/storage/connection/AphrontDatabaseConnection.php

src/aphront/storage/connection/AphrontDatabaseTransactionState.php

src/aphront/storage/connection/AphrontIsolatedDatabaseConnection.php

src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

src/aphront/storage/exception/AphrontParameterQueryException.php

src/aphront/writeguard/AphrontWriteGuard.php

src/auth/PhutilGoogleAuthAdapter.php

src/auth/PhutilJIRAAuthAdapter.php

src/auth/PhutilLDAPAuthAdapter.php

src/auth/PhutilOAuth1AuthAdapter.php

src/auth/PhutilOAuthAuthAdapter.php

src/auth/PhutilPersonaAuthAdapter.php

src/cache/PhutilDirectoryKeyValueCache.php

src/cache/PhutilKeyValueCacheNamespace.php

src/cache/PhutilMemcacheKeyValueCache.php

src/cache/PhutilOnDiskKeyValueCache.php

src/cache/tests/PhutilKeyValueCacheTestCase.php

src/channel/PhutilChannel.php

src/channel/PhutilChannelChannel.php

src/channel/PhutilExecChannel.php

src/channel/PhutilPHPObjectProtocolChannel.php

src/channel/PhutilProtocolChannel.php

src/channel/PhutilSocketChannel.php

src/channel/tests/PhutilJSONProtocolChannelTestCase.php

src/channel/tests/PhutilPHPObjectProtocolChannelTestCase.php

src/conduit/ConduitClient.php

src/console/PhutilConsole.php

src/console/PhutilConsoleProgressBar.php

src/console/PhutilConsoleStdinNotInteractiveException.php

src/console/PhutilInteractiveEditor.php

src/daemon/PhutilDaemon.php

src/daemon/PhutilDaemonHandle.php

src/daemon/PhutilDaemonOverseer.php

src/daemon/torture/PhutilHighIntensityIntervalDaemon.php

src/error/PhutilErrorHandler.php

Loading...

src/error/PhutilOpaqueEnvelope.php

src/error/tests/PhutilErrorHandlerTestCase.php

src/filesystem/FileFinder.php

src/filesystem/Filesystem.php

src/filesystem/PhutilDeferredLog.php

src/filesystem/PhutilDirectoryFixture.php

src/filesystem/PhutilFileLock.php

src/filesystem/PhutilFileTree.php

src/filesystem/PhutilLock.php

src/filesystem/tests/FileFinderTestCase.php

src/filesystem/tests/PhutilDeferredLogTestCase.php

src/filesystem/tests/PhutilFileLockTestCase.php

src/filesystem/linesofalarge/LinesOfALarge.php

src/filesystem/linesofalarge/LinesOfALargeExecFuture.php

src/filesystem/linesofalarge/LinesOfALargeFile.php

src/filesystem/linesofalarge/tests/LinesOfALargeExecFutureTestCase.php

src/filesystem/linesofalarge/tests/LinesOfALargeFileTestCase.php

src/future/Future.php

src/future/FutureIterator.php

src/future/FutureProxy.php

src/future/asana/PhutilAsanaFuture.php

src/future/aws/PhutilAWSException.php

src/future/aws/PhutilAWSFuture.php

src/future/exec/CommandException.php

src/future/exec/ExecFuture.php

src/future/exec/PhutilExecPassthru.php

src/future/http/BaseHTTPFuture.php

src/future/http/HTTPFuture.php

src/future/http/HTTPSFuture.php

src/future/http/status/HTTPFutureCURLResponseStatus.php

src/future/http/status/HTTPFutureCertificateResponseStatus.php

src/future/http/status/HTTPFutureParseResponseStatus.php

src/future/http/status/HTTPFutureTransportResponseStatus.php

src/future/oauth/PhutilOAuth1Future.php

src/future/paypal/PhutilPayPalAPIFuture.php

src/future/twitch/PhutilTwitchFuture.php

src/future/wordpress/PhutilWordPressFuture.php

src/grammar/PhutilContextFreeGrammar.php

src/internationalization/PhutilLocale.php

src/internationalization/PhutilTranslator.php

src/internationalization/tests/PhutilPersonTest.php

src/internationalization/tests/PhutilTranslatorTestCase.php

src/ip/PhutilCIDRBlock.php

src/ip/PhutilIPAddress.php

src/lexer/PhutilLexer.php

src/lexer/tests/PhutilPHPFragmentLexerTestCase.php

src/lexer/tests/PhutilShellLexerTestCase.php

src/markup/tests/PhutilSafeHTMLTestCase.php

src/markup/engine/PhutilRemarkupEngine.php

src/markup/engine/tests/PhutilRemarkupEngineTestCase.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupTableBlockRule.php

src/markup/render.php

src/markup/syntax/engine/tests/PhutilDefaultSyntaxHighlighterEngineTestCase.php

src/markup/syntax/highlighter/tests/PhutilXHPASTSyntaxHighlighterTestCase.php

src/moduleutils/PhutilBootloader.php

src/moduleutils/PhutilLibraryConflictException.php

src/moduleutils/PhutilLibraryMapBuilder.php

src/object/Phobject.php

src/parser/PhutilParserGenerator.php

src/parser/PhutilSimpleOptions.php

src/parser/PhutilTypeSpec.php

src/parser/tests/PhutilDocblockParserTestCase.php

src/parser/tests/PhutilJSONTestCase.php

src/parser/tests/PhutilLanguageGuesserTestCase.php

src/parser/tests/PhutilParserGeneratorTestCase.php

src/parser/tests/PhutilSimpleOptionsTestCase.php

src/parser/argument/PhutilArgumentParser.php

src/parser/argument/PhutilArgumentSpecification.php

src/parser/argument/tests/PhutilArgumentSpecificationTestCase.php

src/parser/argument/workflow/PhutilArgumentWorkflow.php

src/parser/argument/workflow/PhutilHelpArgumentWorkflow.php

src/parser/xhpast/tests/PHPASTParserTestCase.php

src/parser/xhpast/api/XHPASTTree.php

src/parser/xhpast/bin/PhutilXHPASTBinary.php

src/phage/agent/PhagePHPAgent.php

src/phage/bootloader/PhagePHPAgentBootloader.php

src/phage/util/PhutilBallOfPHP.php

src/sprites/PhutilSprite.php

src/sprites/PhutilSpriteSheet.php

src/symbols/PhutilSymbolLoader.php

src/symbols/exception/PhutilMissingSymbolException.php

src/utils/AbstractDirectedGraph.php

src/utils/PhutilCallbackFilterIterator.php

src/utils/PhutilDirectedScalarGraph.php

src/utils/PhutilEditDistanceMatrix.php

src/utils/PhutilSystem.php

src/utils/tests/AbstractDirectedGraphTestCase.php

src/utils/tests/PhutilEditDistanceMatrixTestCase.php

src/utils/tests/PhutilUTF8TestCase.php

src/utils/tests/PhutilUtilsTestCase.php

src/utils/utf8.php

src/utils/utils.php

src/utils/viewutils.php

src/xsprintf/PhutilCommandString.php

src/xsprintf/tests/PhutilCsprintfTestCase.php

src/xsprintf/csprintf.php

src/xsprintf/exception/XsprintfUnknownConversionException.php

src/xsprintf/jsprintf.php

src/xsprintf/qsprintf.php

src/xsprintf/queryfx.php