Page MenuHomePhabricator
Differential D12558

Passphrase credentials should correctly grey out disallowed actions.
ClosedPublic
Actions

Authored by lpriestley on Apr 26 2015, 7:15 PM.
Tags
None
Referenced Files
F14063601: D12558.diff
Mon, Nov 18, 7:28 PM
F13960724: D12558.id30145.diff
Oct 15 2024, 1:01 AM
Unknown Object (File)
Sep 27 2024, 3:18 PM
Unknown Object (File)
Sep 27 2024, 3:16 PM
Unknown Object (File)
Sep 27 2024, 3:15 PM
Unknown Object (File)
Sep 27 2024, 3:13 PM
Unknown Object (File)
Sep 17 2024, 8:06 AM
Unknown Object (File)
Aug 29 2024, 8:37 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7493: Buttons are not consistently greyed out in Passphrase
Commits
Restricted Diffusion Commit
rPf347c002a6c6: Passphrase credentials should correctly grey out disallowed actions.
Summary

Fixes T7493, Credential actions in Passphrase should correclty appear greyed out if clicking them will result in a "You Shall Not Pass" dialog.

Test Plan

Create a credential that is visible to everyone but editable by one, login as a user incapable of editing it, navigate to the credential view, all actions should be greyed out, and all actions should open a "You Shall Not Pass" dialog.

Diff Detail

Repository
rP Phabricator
Branch
passphrasegreyoutimpossibleactions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5514
Build 5533: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30145.Apr 26 2015, 7:15 PM
lpriestley retitled this revision from to Passphrase credentials should correctly grey out disallowed actions..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7493: Buttons are not consistently greyed out in Passphrase.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 26 2015, 7:15 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 26 2015, 7:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2015, 7:17 PM
Closed by commit rPf347c002a6c6: Passphrase credentials should correctly grey out disallowed actions. (authored by lpriestley, committed by epriestley). · Explain WhyApr 26 2015, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
controller/
4 lines

Diff 30145

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
Phabricator · Built by Phacility