Page MenuHomePhabricator
Differential D12532

Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource
ClosedPublic
Actions

Authored by epriestley on Apr 23 2015, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 9:28 PM
Unknown Object (File)
Sun, Dec 22, 3:07 AM
Unknown Object (File)
Sat, Dec 14, 1:17 AM
Unknown Object (File)
Thu, Dec 12, 10:09 PM
Unknown Object (File)
Thu, Dec 12, 9:07 AM
Unknown Object (File)
Fri, Dec 6, 5:31 PM
Unknown Object (File)
Tue, Nov 26, 11:27 PM
Unknown Object (File)
Nov 22 2024, 10:41 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rP83617073f5dc: Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource
Summary

Ref T4100. This improves application scoping (Typeahead -> People) and uses a more consitent and concise name (Parameterized -> Function).

Test Plan
  • grep
  • Used affected datasource.

Diff Detail

Repository
rP Phabricator
Branch
search10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5474
Build 5492: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30080.Apr 23 2015, 3:08 PM
epriestley retitled this revision from to Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 23 2015, 3:08 PM
btrahan accepted this revision.Apr 23 2015, 5:49 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2015, 5:49 PM
Closed by commit rP83617073f5dc: Rename TypehaeadUserParameterizedDatasource to PeopleUserFunctionDatasource (authored by epriestley, committed by epriestley). · Explain WhyApr 23 2015, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
query/
4 lines
maniphest/
query/
4 lines
people/
typeahead/
typeahead/
datasource/
PhabricatorPeopleUserFunctionDatasource.php
PhabricatorTypeaheadUserParameterizedDatasource.php
2 lines
pholio/
query/
2 lines
4 lines
search/
query/
4 lines
typeahead/
datasource/

Diff 30080

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorPeopleUserFunctionDatasource.php

Loading...
View Options

src/applications/pholio/query/PholioMockQuery.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadUserParameterizedDatasource.php

Loading...
Phabricator · Built by Phacility