Paths

Table of Contentst

Improve performance of LINT_UNNECESSARY_SEMICOLON
ClosedPublic
Actions

Authored by joshuaspence on Apr 23 2015, 1:38 AM.

Tags

None

Referenced Files

	F18712519: D12519.id.diff
	Mon, Sep 29, 5:26 AM

	F18658440: D12519.diff
	Tue, Sep 23, 6:28 AM

	F18654369: D12519.id.diff
	Mon, Sep 22, 7:08 AM

	F18207337: D12519.id30058.diff
	Aug 18 2025, 5:37 PM

	F18207336: D12519.id30066.diff
	Aug 18 2025, 5:37 PM

	F18110566: D12519.id30066.diff
	Aug 11 2025, 9:05 PM

	F18088379: D12519.id30058.diff
	Aug 6 2025, 7:41 AM

	F18086487: D12519.id30068.diff
	Aug 5 2025, 10:08 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7892: Investigate lint performance issues

Commits

rARC9ddf37b9ee3e: Improve performance of LINT_UNNECESSARY_SEMICOLON

Summary

Ref T7892. Improve the performance of ArcanistXHPASTLinter::LINT_UNNECESSARY_SEMICOLON.

Test Plan

Wiped 6 seconds off the total time to lint rARC.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30058.Apr 23 2015, 1:38 AM

joshuaspence retitled this revision from to Improve performance of LINT_UNNECESSARY_SEMICOLON.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7892: Investigate lint performance issues.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 23 2015, 1:38 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 23 2015, 1:40 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2015, 1:40 AM

Fix failing test cases

Closed by commit rARC9ddf37b9ee3e: Improve performance of LINT_UNNECESSARY_SEMICOLON (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 23 2015, 10:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

8 lines

Diff 30068

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Improve performance of LINT_UNNECESSARY_SEMICOLONClosedPublicActions