Use a typeahead for "document types" in global search
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 9:55 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPb49645d25b60: Use a typeahead for "document types" in global search

Summary

Now that we have "browse", this is a much more reasonable control for random sets of things.
The new explicit search scope selector reduces the need to fiddle with this field manually, too.

Test Plan

Screen_Shot_2015-04-22_at_2.43.13_PM.png (422×613 px, 47 KB)

Screen_Shot_2015-04-22_at_2.43.23_PM.png (429×1 px, 48 KB)

Diff Detail

Repository

rP Phabricator

Branch

logic16

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5447
Build 5465: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30042.Apr 22 2015, 9:55 PM

epriestley retitled this revision from to Use a typeahead for "document types" in global search.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 9:55 PM

btrahan accepted this revision.Apr 22 2015, 10:16 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2015, 10:16 PM

Closed by commit rPb49645d25b60: Use a typeahead for "document types" in global search (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 10:25 PM

This revision was automatically updated to reflect the committed changes.

Wiki Document tripped me up. Would it be silly to just be 'search by application' ?

I think the only reason these have short names is that they used to be in that checklist. I need to double check that, but now that these are tokens better names are probably "Differential Revision", "Phriction Wiki Document", "Maniphest Task", etc., to hit more reliably on the typeahead.

Some applications have multiple object types (Almanac Service, Almanac Interface; Phame Blog, Phame Post) so I don't want to strictly bind this to applications, even though none of those cases are currently searchable.