Page MenuHomePhabricator
Differential D12493

Track ghostly inlines across file moves
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 12:36 AM
Unknown Object (File)
Sat, Nov 30, 12:29 PM
Unknown Object (File)
Thu, Nov 28, 12:26 AM
Unknown Object (File)
Wed, Nov 20, 11:33 AM
Unknown Object (File)
Nov 15 2024, 11:42 PM
Unknown Object (File)
Nov 12 2024, 5:31 AM
Unknown Object (File)
Nov 12 2024, 12:14 AM
Unknown Object (File)
Nov 8 2024, 5:46 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
T7870: List of cases where ghost comments end up somewhere confusing or unexpected
Commits
Restricted Diffusion Commit
rP8c39885076b5: Track ghostly inlines across file moves
Summary

Ref T7447. Ref T7870.

  • Forward: When rendering some file "B" which was moved from "A", port ghosts for both "A" and "B" to it.
  • Backward: When porting a comment on "X" which was moved from some "Y", allow it to port to a file named "Y" if it can't find a file named "X".
Test Plan

Before:

move.png (618×1 px, 100 KB)

After:

Screen_Shot_2015-04-21_at_8.33.57_AM.png (885×1 px, 118 KB)

Diff Detail

Repository
rP Phabricator
Branch
ghost7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5420
Build 5438: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29988.Apr 21 2015, 3:34 PM
epriestley retitled this revision from to Track ghostly inlines across file moves.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7870: List of cases where ghost comments end up somewhere confusing or unexpected, T7447: Bring inline comments forward across revision updates.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 3:34 PM
epriestley edited the test plan for this revision. (Show Details)Apr 21 2015, 3:34 PM
epriestley mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
btrahan accepted this revision.Apr 21 2015, 5:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:38 PM
Closed by commit rP8c39885076b5: Track ghostly inlines across file moves (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
77 lines

Diff 29988

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
Phabricator · Built by Phacility