Prefer left-side for old comments in new-vs-new diff of diffs
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 1:07 PM.

Details

Reviewers

Maniphest Tasks

T7870: List of cases where ghost comments end up somewhere confusing or unexpected
T7447: Bring inline comments forward across revision updates

Commits

Restricted Diffusion Commit
rPaa04e97de7e1: Prefer left-side for old comments in new-vs-new diff of diffs

Summary

Ref T7447. Ref T7870.

Test Plan

Before:

After:

Screen_Shot_2015-04-21_at_6.03.56_AM.png (294×753 px, 31 KB)

Diff Detail

Repository

rP Phabricator

Branch

ghost4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5422
Build 5440: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29984.Apr 21 2015, 1:07 PM

epriestley retitled this revision from to Prefer left-side for old comments in new-vs-new diff of diffs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7447: Bring inline comments forward across revision updates, T7870: List of cases where ghost comments end up somewhere confusing or unexpected.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 1:07 PM

T7870 has a detailed description of the underlying issue here.

src/applications/differential/controller/DifferentialChangesetViewController.php
324–333	This also hopefully explains it.

epriestley mentioned this in T7870: List of cases where ghost comments end up somewhere confusing or unexpected.Apr 21 2015, 1:24 PM

btrahan accepted this revision.Apr 21 2015, 5:32 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/differential/controller/DifferentialChangesetViewController.php
324–332	s/briging/bringing
328	"human" is a bit too broad I think. e.g. I believe japanese is read right to left

This revision is now accepted and ready to land.Apr 21 2015, 5:32 PM

Well, human users of Differential, where the old diff is always displayed on the left.

Spelling fix.
Increase cultural awareness.

Closed by commit rPaa04e97de7e1: Prefer left-side for old comments in new-vs-new diff of diffs (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 6:12 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7447: Bring inline comments forward across revision updates.Apr 21 2015, 6:22 PM

chad added a subscriber: chad.Apr 21 2015, 6:50 PM

chad added inline comments.

src/applications/differential/controller/DifferentialChangesetViewController.php
328	I don't think Japanese is an RTL language on the web. (sorry just wanted to test a reply).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

53 lines

Diff 29991

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Prefer left-side for old comments in new-vs-new diff of diffsClosedPublicActions