Page MenuHomePhabricator

Modernize DifferentialInlineCommentQuery
ClosedPublic

Authored by epriestley on Apr 20 2015, 9:36 PM.
Tags
None
Referenced Files
F14061220: D12483.diff
Mon, Nov 18, 5:38 AM
F14048463: D12483.diff
Thu, Nov 14, 7:50 AM
F14035199: D12483.diff
Sun, Nov 10, 4:50 AM
F14020852: D12483.diff
Wed, Nov 6, 3:05 AM
F14003330: D12483.diff
Sat, Oct 26, 4:56 AM
F13987239: D12483.id29993.diff
Mon, Oct 21, 8:16 AM
Unknown Object (File)
Oct 6 2024, 12:41 PM
Unknown Object (File)
Sep 20 2024, 3:28 PM

Details

Summary

Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.

Try to generalize/normalize it a bit.

Test Plan
  • Viewed inline comments.
  • Created a new inline comment.
  • Edited an inline comment.
  • Marked an inline comment complete.
  • Deleted, then undeleted an inline comment.
  • Previewed inline comments.
  • Viewed drafts as another user, verified they don't show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize DifferentialInlineCommentQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.