Page MenuHomePhabricator

Modernize DifferentialInlineCommentQuery
ClosedPublic

Authored by epriestley on Apr 20 2015, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:27 AM
Unknown Object (File)
Fri, Apr 19, 7:12 AM
Unknown Object (File)
Sat, Apr 13, 8:49 PM
Unknown Object (File)
Tue, Apr 9, 2:43 AM
Unknown Object (File)
Thu, Apr 4, 9:04 AM
Unknown Object (File)
Sat, Mar 30, 7:02 PM
Unknown Object (File)
Mar 21 2024, 10:23 AM
Unknown Object (File)
Feb 16 2024, 8:26 PM

Details

Summary

Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.

Try to generalize/normalize it a bit.

Test Plan
  • Viewed inline comments.
  • Created a new inline comment.
  • Edited an inline comment.
  • Marked an inline comment complete.
  • Deleted, then undeleted an inline comment.
  • Previewed inline comments.
  • Viewed drafts as another user, verified they don't show up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize DifferentialInlineCommentQuery.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 10:42 PM
This revision was automatically updated to reflect the committed changes.