Conpherence - get #anchor links to messages working
ClosedPublic
Actions

Authored by btrahan on Apr 13 2015, 9:40 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7757: Conpherence rooms should offer permanent links to a specific message

Commits

Restricted Diffusion Commit
rP0acdf256fc9d: Conpherence - get #anchor links to messages working

Summary

Ref T7757. Oddities include:

not working in column view, since the generic anchor technology conflicts once you navigate to a page with a transaction timeline view
not working if you are linking to a message not included in initial load

Remaining work is addressing these oddities.

make column view timestamp link to full conpherence correctly?
make back end load from hyperlinked transaction forward? or do it more like application transactions and have the client keep requesting stuff until it gets it?

Open to suggestions! :D

Test Plan

played around in conpherence full and stuff looked okay. noted no changes as intended in column view.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29789.Apr 13 2015, 9:40 PM

btrahan added a task: T7757: Conpherence rooms should offer permanent links to a specific message.

btrahan retitled this revision from to Conpherence - get #anchor links to messages working.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptApr 13 2015, 9:40 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

make column view timestamp link to full conpherence correctly?

This sounds desirable to me. I don't think we should permalink into the column since it seems like tons of bad news.

make back end load from hyperlinked transaction forward? or do it more like application transactions and have the client keep requesting stuff until it gets it?

I think full-text search and link-to-message might both benefit from some kind of "snippet" view which shows a historical piece of context. It's very rare for an object to have 5,000 transactions, but pretty common for chat to have 5,000 messages, and doing 50 sequential loads to rewind history seems pretty sketchy. Not exactly sure what this should look like, though.

This revision is now accepted and ready to land.Apr 13 2015, 9:48 PM