Page MenuHomePhabricator
Differential D12397

Conpherence - make `ZXXX` monograms a bit more useful.
ClosedPublic
Actions

Authored by btrahan on Apr 13 2015, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 4:12 PM
Unknown Object (File)
Sun, Jan 26, 4:12 PM
Unknown Object (File)
Sun, Jan 26, 4:12 PM
Unknown Object (File)
Sun, Jan 26, 4:12 PM
Unknown Object (File)
Sat, Jan 25, 4:28 PM
Unknown Object (File)
Fri, Jan 24, 2:35 AM
Unknown Object (File)
Fri, Jan 24, 2:35 AM
Unknown Object (File)
Fri, Jan 24, 2:34 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7756: Conpherence threads should support monograms
Commits
Restricted Diffusion Commit
rPdd22db18ff82: Conpherence - make `ZXXX` monograms a bit more useful.
Summary

Ref T7756. Now viewing individual threads in Conpherence is ZXXX driven. Also adds remarkup support.

Test Plan

clicked around on list of conpherences in full view and it worked. selected 'view in conpherence' action from column and loaded correct ZXXX uri. Typed ZXXX in Maniphest and saw it link to Conpherence room.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29772.Apr 13 2015, 7:32 PM
btrahan added a task: T7756: Conpherence threads should support monograms.
btrahan retitled this revision from to Conpherence - make `ZXXX` monograms a bit more useful..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 7:32 PM
epriestley accepted this revision.Apr 13 2015, 7:36 PM
epriestley edited edge metadata.

One inline.

src/applications/conpherence/application/PhabricatorConpherenceApplication.php
72

This probably needs to be /Z\d+ or similar, as written this will match /, /Z, /ZZ, etc.

This revision is now accepted and ready to land.Apr 13 2015, 7:36 PM
btrahan updated this revision to Diff 29777.Apr 13 2015, 7:45 PM
btrahan edited edge metadata.

fix over ambitious regex (test that ZXX still can't turn on durable column)

Closed by commit rPdd22db18ff82: Conpherence - make `ZXXX` monograms a bit more useful. (authored by btrahan, committed by btrahan). · Explain WhyApr 13 2015, 7:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
32 lines
src/
2 lines
applications/
conpherence/
application/
8 lines
phid/
2 lines
remarkup/
19 lines
view/
2 lines
2 lines
webroot/
rsrc/
js/
application/
conpherence/
7 lines

Diff 29778

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

Loading...
View Options

src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php

Loading...
View Options

src/applications/conpherence/remarkup/ConpherenceThreadRemarkupRule.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
Phabricator · Built by Phacility