Page MenuHomePhabricator
Differential D12393

Minor tidying of `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 12:41 PM.
Tags
None
Referenced Files
F14096565: D12393.diff
Tue, Nov 26, 4:05 AM
Unknown Object (File)
Sat, Nov 23, 9:49 AM
Unknown Object (File)
Tue, Nov 19, 6:54 AM
Unknown Object (File)
Fri, Nov 15, 4:13 AM
Unknown Object (File)
Mon, Nov 11, 3:24 AM
Unknown Object (File)
Thu, Nov 7, 6:24 AM
Unknown Object (File)
Oct 21 2024, 10:20 PM
Unknown Object (File)
Oct 21 2024, 11:07 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCeb036465dc9b: Minor tidying of `ArcanistXHPASTLinter`
Summary

Modernizing a couple of linter rules.

Test Plan

Unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5287
Build 5305: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29741.Apr 13 2015, 12:41 PM
joshuaspence retitled this revision from to Minor tidying of `ArcanistXHPASTLinter`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 12:41 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 13 2015, 2:28 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 2:28 PM
Closed by commit rARCeb036465dc9b: Minor tidying of `ArcanistXHPASTLinter` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
140 lines

Diff 29741

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility