Page MenuHomePhabricator
Differential D12390

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 10:59 AM.
Tags
None
Referenced Files
F14050992: D12390.id30877.diff
Thu, Nov 14, 9:53 PM
F14029720: D12390.id30877.diff
Fri, Nov 8, 9:00 PM
F14012377: D12390.id.diff
Fri, Nov 1, 11:11 AM
F14012376: D12390.id31157.diff
Fri, Nov 1, 11:11 AM
F14012374: D12390.id31090.diff
Fri, Nov 1, 11:11 AM
F14012372: D12390.id30726.diff
Fri, Nov 1, 11:11 AM
F14012371: D12390.id29736.diff
Fri, Nov 1, 11:11 AM
F14012370: D12390.id30877.diff
Fri, Nov 1, 11:11 AM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPc896aeb62ed9: Various linter fixes
Summary

Apply various linter fixes.

Test Plan

Unit tests + eyeballing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29736.Apr 13 2015, 10:59 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 10:59 AM
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript
joshuaspence updated this revision to Diff 30726.May 9 2015, 2:26 AM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 30877.May 14 2015, 10:54 AM

Further fixes

joshuaspence updated this revision to Diff 31090.May 19 2015, 12:48 PM

More fixes

epriestley accepted this revision.May 19 2015, 3:12 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 3:12 PM
Closed by commit rPc896aeb62ed9: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
82 lines
6 lines
response/
2 lines
applications/
celerity/
2 lines
conpherence/
controller/
2 lines
dashboard/
engine/
4 lines
diffusion/
data/
30 lines
query/
2 lines
pathchange/
8 lines
files/
storage/
2 lines
herald/
adapter/
6 lines
legalpad/
controller/
2 lines
metamta/
storage/
2 lines
notification/
controller/
2 lines
oauthserver/
2 lines
owners/
controller/
2 lines
2 lines
people/
controller/
4 lines
pholio/
editor/
6 lines
view/
4 lines
project/
editor/
2 lines
releeph/
conduit/
work/
2 lines
differential/
2 lines
editor/
2 lines
storage/
7 lines
4 lines
tokens/
query/
2 lines
transactions/
view/
2 lines
infrastructure/
events/
4 lines
storage/
configuration/
2 lines
lisk/
2 lines
view/
2 lines
6 lines
control/
28 lines
20 lines
form/
2 lines
layout/
2 lines
phui/
2 lines

Diff 31157

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/aphront/AphrontURIMapper.php

Loading...
View Options

src/aphront/response/AphrontJSONResponse.php

Loading...
View Options

src/applications/celerity/CelerityResourceGraph.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/diffusion/data/DiffusionPathChange.php

Loading...
View Options

src/applications/diffusion/query/DiffusionRenameHistoryQuery.php

Loading...
View Options

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/oauthserver/PhabricatorOAuthServer.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersListController.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleController.php

Loading...
View Options

src/applications/pholio/editor/PholioMockEditor.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/releeph/conduit/work/ReleephWorkNextRequestConduitAPIMethod.php

Loading...
View Options

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

Loading...
View Options

src/applications/releeph/editor/ReleephRequestTransactionalEditor.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequest.php

Loading...
View Options

src/applications/releeph/storage/ReleephRequestTransaction.php

Loading...
View Options

src/applications/tokens/query/PhabricatorTokenCountQuery.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/infrastructure/events/PhabricatorEvent.php

Loading...
View Options

src/infrastructure/storage/configuration/DefaultDatabaseConfigurationProvider.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAOSet.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/AphrontJavelinView.php

Loading...
View Options

src/view/control/AphrontCursorPagerView.php

Loading...
View Options

src/view/control/AphrontPagerView.php

Loading...
View Options

src/view/form/PHUIInfoView.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
Phabricator · Built by Phacility