Paths

Table of Contentst

Differential D12385

Improvements to "self member reference" linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 8:06 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCc011f948d3f7: Improvements to "self member reference" linter rule

Summary

Ref T7409. A few fixes and improvements to ArcanistXHPASTLinter::LINT_SELF_MEMBER_REFERENCE.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5276
Build 5294: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29729.Apr 13 2015, 8:06 AM

joshuaspence retitled this revision from to Improvements to "self member reference" linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 8:06 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 13 2015, 2:22 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 2:22 PM

Closed by commit rARCc011f948d3f7: Improvements to "self member reference" linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

39 lines

__tests__/

xhpast/

self-member-references.lint-test

14 lines

Diff 29729

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/self-member-references.lint-test

Improvements to "self member reference" linter ruleClosedPublicActions