Page MenuHomePhabricator
Differential D12370

Add a linter rule for self member references
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 12:59 PM.
Tags
None
Referenced Files
F14758594: D12370.diff
Wed, Jan 22, 7:59 AM
F14754428: D12370.id29714.diff
Tue, Jan 21, 3:32 PM
F14751043: D12370.id.diff
Tue, Jan 21, 12:05 PM
Unknown Object (File)
Wed, Jan 15, 12:09 AM
Unknown Object (File)
Mon, Jan 13, 4:25 PM
Unknown Object (File)
Sun, Jan 12, 4:19 PM
Unknown Object (File)
Thu, Jan 2, 3:35 PM
Unknown Object (File)
Sun, Dec 29, 10:54 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCfc70dfe268f8: Add a linter rule for self member references
Summary

Ref T7409. Adds a linter rule for the following:

  • self:: is used instead of Self::.
  • self:: is used for local static member reference.
  • self:: is used instead of self ::.

Based on Squiz_Sniffs_Classes_SelfMemberReferenceSniff.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5266
Build 5284: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29698.Apr 12 2015, 12:59 PM
joshuaspence retitled this revision from to Add a linter rule for self member references.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 12:59 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 12 2015, 1:00 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 1:00 PM
joshuaspence updated this revision to Diff 29713.Apr 12 2015, 9:30 PM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this revision to Diff 29714.Apr 12 2015, 9:33 PM

Minor changes

Closed by commit rARCfc70dfe268f8: Add a linter rule for self member references (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
70 lines
__tests__/
xhpast/
46 lines

Diff 29713

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/self-member-references.lint-test

Loading...
Phabricator · Built by Phacility