Paths

Table of Contentst

Differential D12368

Further improvements to keyword casing linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 11:35 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARC6525a309c29f: Further improvements to keyword casing linter rule

Summary

Ref T7409. Improve the ArcanistXHPASTLinter::LINT_KEYWORD_CASING linter rule to check that magic constants are uppercase.

Test Plan

Added unit test.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5252
Build 5270: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29696.Apr 12 2015, 11:35 AM

joshuaspence retitled this revision from to Further improvements to keyword casing linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 11:35 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 12 2015, 12:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 12 2015, 12:18 PM

Closed by commit rARC6525a309c29f: Further improvements to keyword casing linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

23 lines

__tests__/

xhpast/

keyword-casing.lint-test

5 lines

Diff 29696

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/keyword-casing.lint-test

Further improvements to keyword casing linter ruleClosedPublicActions