Paths

Table of Contentst

Differential D12367

Improve `LINT_KEYWORD_CASING` linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 11:24 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule

Summary

Ref T7409. Improve ArcanistXHPASTLinter::LINT_KEYWORD_CASING to include additional token types. Based on Generic_Sniffs_PHP_LowerCaseKeywordSniff.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5251
Build 5269: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29695.Apr 12 2015, 11:24 AM

joshuaspence retitled this revision from to Improve `LINT_KEYWORD_CASING` linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 11:24 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 12 2015, 12:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 12 2015, 12:19 PM

Closed by commit rARC515e98f1d297: Improve `LINT_KEYWORD_CASING` linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

150 lines

Diff 29695

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Improve `LINT_KEYWORD_CASING` linter ruleClosedPublicActions