Page MenuHomePhabricator
Differential D12366

Add a linter rule for uppercase constant definitions
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 10:05 AM.
Tags
None
Referenced Files
F18185032: D12366.id29712.diff
Sat, Aug 16, 2:54 PM
F18099039: D12366.id29716.diff
Sat, Aug 9, 12:53 AM
F18065034: D12366.id29694.diff
Mon, Aug 4, 1:59 PM
F18054577: D12366.id.diff
Mon, Aug 4, 6:22 AM
F18050670: D12366.diff
Sun, Aug 3, 8:39 PM
Unknown Object (File)
Jul 3 2025, 10:26 AM
Unknown Object (File)
May 7 2025, 10:13 PM
Unknown Object (File)
May 7 2025, 6:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCf86f4f24e617: Add a linter rule for uppercase constant definitions
Summary

Ref T7409. Adds a linter rule to ensure that constant are defined as being uppercase. Based on Generic_Sniffs_NamingConventions_UpperCaseConstantNameSniff.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5265
Build 5283: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29694.Apr 12 2015, 10:05 AM
joshuaspence retitled this revision from to Add a linter rule for uppercase constant definitions.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 10:05 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Apr 12 2015, 11:48 AM
joshuaspence edited edge metadata.
epriestley accepted this revision.Apr 12 2015, 12:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 12:18 PM
joshuaspence updated this revision to Diff 29712.Apr 12 2015, 9:24 PM
joshuaspence edited edge metadata.

Change to LINT_NAMING_CONVENTIONS

Closed by commit rARCf86f4f24e617: Add a linter rule for uppercase constant definitions (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
80 lines
__tests__/
xhpast/
12 lines
4 lines

Diff 29712

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/constant-case.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/dynamic-define.lint-test

Loading...
Phabricator · Built by Phacility