Page MenuHomePhabricator
Differential D12341

Clean up some more handle callsites
ClosedPublic
Actions

Authored by epriestley on Apr 9 2015, 10:34 PM.
Tags
None
Referenced Files
F18428393: D12341.id.diff
Sun, Aug 31, 1:29 AM
F18426809: D12341.id29650.diff
Sat, Aug 30, 11:19 PM
F18093058: D12341.id29655.diff
Thu, Aug 7, 3:07 PM
F18088178: D12341.id.diff
Wed, Aug 6, 7:08 AM
F18086817: D12341.diff
Wed, Aug 6, 12:18 AM
Unknown Object (File)
Jul 3 2025, 9:40 PM
Unknown Object (File)
Jun 20 2025, 5:03 PM
Unknown Object (File)
Jun 2 2025, 6:24 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7689: Load handles just-in-time
Commits
Restricted Diffusion Commit
rPd44f05eead96: Clean up some more handle callsites
Summary

Ref T7689.

Test Plan
  • Viewed Calendar browse and detail views.
  • Went through Differential update workflow.

Diff Detail

Repository
rP Phabricator
Branch
hand2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5220
Build 5238: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29650.Apr 9 2015, 10:34 PM
epriestley retitled this revision from to Clean up some more handle callsites.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7689: Load handles just-in-time.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 9 2015, 10:34 PM
btrahan accepted this revision.Apr 9 2015, 10:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 9 2015, 10:36 PM
Closed by commit rPd44f05eead96: Clean up some more handle callsites (authored by epriestley, committed by epriestley). · Explain WhyApr 9 2015, 11:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29650

View Options

src/applications/calendar/controller/PhabricatorCalendarBrowseController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

Loading...
Phabricator · Built by Phacility