Fix two minor CSS states with Done button
ClosedPublic
Actions

Authored by chad on Apr 7 2015, 6:02 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7737: "Done" button has misleading UI states

Commits

Restricted Diffusion Commit
rPcefdca164422: Fix two minor CSS states with Done button

Summary

Fixes T7737, gets rid of not-done hover yellow, and removed the pointer on button-done state for reviewer.

Test Plan

tested numerous states as reviewer and author. Rechecked done on a few items. Verify new states work. This still seems fragile.

Diff Detail

Repository

rP Phabricator

Branch

done-tweaks

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5181
Build 5199: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29584.Apr 7 2015, 6:02 PM

chad retitled this revision from to Fix two minor CSS states with Done button.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7737: "Done" button has misleading UI states.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 7 2015, 6:02 PM

epriestley accepted this revision.Apr 7 2015, 6:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 7 2015, 6:53 PM

Closed by commit rPcefdca164422: Fix two minor CSS states with Done button (authored by chad, committed by chad). · Explain WhyApr 7 2015, 6:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

differential/

phui-inline-comment.css

5 lines

Diff 29584

View Options

resources/celerity/map.php