Fixes T7765. The existing sort was based on when people were added to the conpherence and basically feels random in time. Instead, sort current logged in user to the top and make the rest of the list alphabetical.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7765: Room and thread participant lists should sort alphabetically
- Commits
- Restricted Diffusion Commit
rP3a72e53795c6: Conpherence - sort participant list in main conpherence with an actual algorithm
viewed a conpherenece and noted my logged in user at top and the rest was sorted alphabetically
viewed a room that i was not a participant in and participant list rendered correctly
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7765
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5158 Build 5176: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/conpherence/view/ConpherencePeopleWidgetView.php | ||
|---|---|---|
| 12–17 | Not sure if this is too gross versus a custom comparator. | |
Comment Actions
You can also write that like, e.g.:
$head_handles = array_select_keys($handles, array($user_phid)); $handles = $head_handles + $handles;