Page MenuHomePhabricator
Differential D12292

Mark some AAST methods as final
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 10:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 2:38 AM
Unknown Object (File)
Wed, Jan 29, 2:34 AM
Unknown Object (File)
Tue, Jan 28, 8:56 PM
Unknown Object (File)
Mon, Jan 27, 2:27 PM
Unknown Object (File)
Mon, Jan 27, 2:40 AM
Unknown Object (File)
Sun, Jan 26, 6:14 AM
Unknown Object (File)
Fri, Jan 24, 2:12 AM
Unknown Object (File)
Fri, Jan 24, 2:11 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU37119b5a2140: Mark some AAST methods as final
Summary

Self-explanatory. I don't think any subclasses should reasonably override these methods.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5147
Build 5165: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29495.Apr 5 2015, 10:23 AM
joshuaspence retitled this revision from to Mark some AAST methods as final.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 10:23 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:15 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/parser/xhpast/api/XHPASTNode.php
233–235

This has no callsites?

This revision is now accepted and ready to land.Apr 5 2015, 12:15 PM
joshuaspence added inline comments.Apr 5 2015, 12:16 PM
src/parser/xhpast/api/XHPASTNode.php
233–235

This method is identical to the implementation in AASTNode.

joshuaspence updated this revision to Diff 29521.Apr 5 2015, 12:44 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rPHU37119b5a2140: Mark some AAST methods as final (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
22 lines
8 lines
20 lines
xhpast/
api/
4 lines

Diff 29521

View Options

src/parser/aast/api/AASTNode.php

Loading...
View Options

src/parser/aast/api/AASTToken.php

Loading...
View Options

src/parser/aast/api/AASTTree.php

Loading...
View Options

src/parser/xhpast/api/XHPASTNode.php

Loading...
Phabricator · Built by Phacility