Page MenuHomePhabricator
Differential D12289

Add typeName attribute to AASTToken
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 10:07 AM.
Tags
None
Referenced Files
F15525539: D12289.diff
Mon, Apr 21, 3:09 PM
F15490660: D12289.diff
Fri, Apr 11, 7:30 PM
F15490223: D12289.id29516.diff
Fri, Apr 11, 3:21 PM
F15460596: D12289.id.diff
Tue, Apr 1, 12:18 AM
F15441837: D12289.diff
Wed, Mar 26, 8:17 PM
F15421470: D12289.id29516.diff
Mar 22 2025, 12:03 AM
F15407304: D12289.diff
Mar 18 2025, 4:49 PM
F15380799: D12289.id29492.diff
Mar 14 2025, 4:30 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU5d55911240fd: Add typeName attribute to AASTToken
Summary

This attribute implicitly exists because it is created by getTypeName() method.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5133
Build 5151: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29492.Apr 5 2015, 10:07 AM
joshuaspence retitled this revision from to Add typeName attribute to AASTToken.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 10:07 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2015, 12:16 PM
Closed by commit rPHU5d55911240fd: Add typeName attribute to AASTToken (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
3 lines

Diff 29492

View Options

src/parser/aast/api/AASTToken.php

Loading...
Phabricator · Built by Phacility