Page MenuHomePhabricator
Differential D12287

Simplify `AASTNodeList::selectDescendantsOfType`
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2025, 8:22 AM
Unknown Object (File)
Apr 28 2025, 7:01 AM
Unknown Object (File)
Apr 25 2025, 8:18 PM
Unknown Object (File)
Apr 21 2025, 2:11 AM
Unknown Object (File)
Apr 4 2025, 9:13 AM
Unknown Object (File)
Mar 29 2025, 9:06 AM
Unknown Object (File)
Mar 28 2025, 3:16 PM
Unknown Object (File)
Mar 20 2025, 7:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType`
Summary

Rewrite AASTNodeList::selectDescendantsOfType to just call AASTNodeList::selectDescendantsOfTypes, minimizing code duplication.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29490.Apr 5 2015, 9:55 AM
joshuaspence retitled this revision from to Simplify `AASTNodeList::selectDescendantsOfType`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:55 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2015, 12:17 PM
Closed by commit rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
6 lines

Diff 29511

View Options

src/parser/aast/api/AASTNodeList.php

Loading...
Phabricator · Built by Phacility