Page MenuHomePhabricator
Differential D12287

Simplify `AASTNodeList::selectDescendantsOfType`
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:55 AM.
Tags
None
Referenced Files
F15523560: D12287.id29490.diff
Mon, Apr 21, 2:11 AM
F15469114: D12287.diff
Fri, Apr 4, 9:13 AM
F15453064: D12287.id29511.diff
Sat, Mar 29, 9:06 AM
F15450364: D12287.id.diff
Fri, Mar 28, 3:16 PM
F15415746: D12287.id29511.diff
Mar 20 2025, 7:43 AM
F15404229: D12287.id.diff
Mar 18 2025, 6:51 AM
F15400506: D12287.diff
Mar 17 2025, 12:08 PM
Unknown Object (File)
Mar 3 2025, 11:22 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType`
Summary

Rewrite AASTNodeList::selectDescendantsOfType to just call AASTNodeList::selectDescendantsOfTypes, minimizing code duplication.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29490.Apr 5 2015, 9:55 AM
joshuaspence retitled this revision from to Simplify `AASTNodeList::selectDescendantsOfType`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:55 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:17 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2015, 12:17 PM
Closed by commit rPHUb4817f21fb98: Simplify `AASTNodeList::selectDescendantsOfType` (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
6 lines

Diff 29511

View Options

src/parser/aast/api/AASTNodeList.php

Loading...
Phabricator · Built by Phacility