Page MenuHomePhabricator
Differential D12283

Fix linter issues in a `@nolint` file
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:15 AM.
Tags
None
Referenced Files
F13253837: D12283.diff
Sat, May 25, 2:59 AM
F13232192: D12283.diff
Tue, May 21, 1:05 AM
F13204308: D12283.id29505.diff
Wed, May 15, 12:28 AM
F13204307: D12283.id29486.diff
Wed, May 15, 12:28 AM
F13204114: D12283.id.diff
Wed, May 15, 12:21 AM
F13203658: D12283.diff
Tue, May 14, 11:58 PM
F13186919: D12283.diff
Sat, May 11, 4:12 AM
F13182965: D12283.id29505.diff
Fri, May 10, 5:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file
Summary

This file is still marked as @nolint, but at least it is more consistent with our coding style.

Test Plan

Unit tests still pass?

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5127
Build 5145: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29486.Apr 5 2015, 9:15 AM
joshuaspence retitled this revision from to Fix linter issues in a `@nolint` file.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:15 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:18 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2015, 12:18 PM
Closed by commit rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
xhpast/
api/
__tests__/
10 lines

Diff 29486

View Options

src/parser/xhpast/api/__tests__/XHPASTTreeTestCase.php

Loading...
Phabricator · Built by Phacility