Paths

Table of Contentst

Differential D12283

Fix linter issues in a `@nolint` file
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:15 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file

Summary

This file is still marked as @nolint, but at least it is more consistent with our coding style.

Test Plan

Unit tests still pass?

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5127
Build 5145: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29486.Apr 5 2015, 9:15 AM

joshuaspence retitled this revision from to Fix linter issues in a `@nolint` file.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:15 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 5 2015, 12:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2015, 12:18 PM

Closed by commit rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

api/

__tests__/

XHPASTTreeTestCase.php

10 lines

Diff 29486

View Options

src/parser/xhpast/api/tests/XHPASTTreeTestCase.php

Fix linter issues in a `@nolint` fileClosedPublicActions