Paths

Table of Contentst

Fix linter issues in a `@nolint` file
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 9:15 AM.

Tags

None

Referenced Files

	F15467617: D12283.diff
	Thu, Apr 3, 4:55 PM

	F15463560: D12283.id29505.diff
	Wed, Apr 2, 12:54 AM

	F15455221: D12283.id.diff
	Sat, Mar 29, 10:56 PM

	F15435593: D12283.id29486.diff
	Tue, Mar 25, 9:07 AM

	F15420313: D12283.id29505.diff
	Fri, Mar 21, 1:01 PM

	F15408173: D12283.id29486.diff
	Tue, Mar 18, 9:33 PM

	F15401028: D12283.diff
	Mon, Mar 17, 3:18 PM

	F15358873: D12283.id29505.diff
	Tue, Mar 11, 7:32 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file

Summary

This file is still marked as @nolint, but at least it is more consistent with our coding style.

Test Plan

Unit tests still pass?

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29486.Apr 5 2015, 9:15 AM

joshuaspence retitled this revision from to Fix linter issues in a `@nolint` file.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 9:15 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 5 2015, 12:18 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 5 2015, 12:18 PM

Closed by commit rPHU9a6d307d2a58: Fix linter issues in a `@nolint` file (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

api/

__tests__/

XHPASTTreeTestCase.php

10 lines

Diff 29505

View Options

src/parser/xhpast/api/tests/XHPASTTreeTestCase.php

Fix linter issues in a `@nolint` fileClosedPublicActions