Page MenuHomePhabricator

Update script for compatibility with PHP CompatInfo v4.0.0
ClosedPublic

Authored by joshuaspence on Apr 5 2015, 5:18 AM.
Tags
None
Referenced Files
F18084422: D12278.diff
Tue, Aug 5, 3:23 PM
Unknown Object (File)
Jun 7 2025, 7:22 PM
Unknown Object (File)
May 31 2025, 11:31 AM
Unknown Object (File)
May 31 2025, 11:31 AM
Unknown Object (File)
May 31 2025, 11:31 AM
Unknown Object (File)
May 25 2025, 3:17 AM
Unknown Object (File)
May 10 2025, 6:04 PM
Unknown Object (File)
May 8 2025, 8:57 PM
Subscribers

Details

Summary

The API for PHP CompatInfo changed significantly in v4.0.0 and therefore this script needs to be updated. One of the major differences is that the data is now stored in an SQLite database and JSON files rather than in PHP source code.

Another noticable difference is that the newer version is missing information regarding the compatibility of class methods. I have filled an upstream issue for this, but I don't consider this to be hugely significant as they data isn't currently used.

I also took this opportunity to tweak the output format to include some additional fields (although I have no immediate plans to use these fields).

Test Plan

Eyeballed the output. The main thing that looked out of place was the following, which seems wrong to me:

"opcache_compile_file": {
  "min": "5.2.0",
  "max": null,
  "ref": "Zend OPcache"
},
"opcache_is_script_cached": {
  "min": "5.2.0",
  "max": null,
  "ref": "Zend OPcache"
},

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
SeverityLocationCodeMessage
Advicescripts/update_compat_info.php:84XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 5122
Build 5140: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Update script for compatibility with PHP CompatInfo v4.0.0.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Simplify logic for parsing parameter counts

epriestley edited edge metadata.

I have zero clue what I ran locally, then, if it also clearly wasn't 4.0.0. I guess I am exceptionally bad at using Composer.

iiam

This revision is now accepted and ready to land.Apr 6 2015, 1:21 PM
This revision was automatically updated to reflect the committed changes.