Page MenuHomePhabricator
Differential D12269

Attach HeraldRules to HeraldEffects
ClosedPublic
Actions

Authored by epriestley on Apr 4 2015, 12:26 AM.
Tags
None
Referenced Files
F13961801: D12269.id.diff
Tue, Oct 15, 6:26 AM
F13961144: D12269.diff
Tue, Oct 15, 3:24 AM
F13955462: D12269.id29467.diff
Mon, Oct 14, 1:34 AM
Unknown Object (File)
Thu, Oct 3, 12:47 AM
Unknown Object (File)
Sep 11 2024, 2:53 PM
Unknown Object (File)
Aug 25 2024, 7:02 PM
Unknown Object (File)
Aug 23 2024, 8:30 PM
Unknown Object (File)
Aug 8 2024, 5:40 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7731: Make "Send me an email" force mail delivery through notification preferences
Commits
Restricted Diffusion Commit
rP63f4e66b1122: Attach HeraldRules to HeraldEffects
Summary

Ref T7731. For no particular reason, we currently put ruleID and rulePHID on HeraldEffect objects.

Pretty much all callers need the HeraldRule objects instead, and some go to great lengths to get them.

Just attach the Rule objects.

Test Plan

Will test thoroughly after next-ish changeset.

Diff Detail

Repository
rP Phabricator
Branch
hmail3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5111
Build 5129: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29467.Apr 4 2015, 12:26 AM
epriestley retitled this revision from to Attach HeraldRules to HeraldEffects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7731: Make "Send me an email" force mail delivery through notification preferences.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 4 2015, 12:26 AM
btrahan accepted this revision.Apr 6 2015, 4:11 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1002

woot!

This revision is now accepted and ready to land.Apr 6 2015, 4:11 PM
Closed by commit rP63f4e66b1122: Attach HeraldRules to HeraldEffects (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
11 lines
diffusion/
engine/
16 lines
herald/
adapter/
7 lines
4 lines
engine/
22 lines
14 lines
storage/
4 lines
transcript/
2 lines

Diff 29467

View Options

src/applications/differential/editor/DifferentialDiffEditor.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...
View Options

src/applications/herald/engine/HeraldEffect.php

Loading...
View Options

src/applications/herald/engine/HeraldEngine.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldApplyTranscript.php

Loading...
Phabricator · Built by Phacility