Page MenuHomePhabricator

Attach HeraldRules to HeraldEffects
ClosedPublic

Authored by epriestley on Apr 4 2015, 12:26 AM.
Tags
None
Referenced Files
F13232319: D12269.id29540.diff
Tue, May 21, 1:12 AM
F13228852: D12269.id.diff
Mon, May 20, 12:41 PM
F13224048: D12269.id29467.diff
May 19 2024, 6:05 AM
F13216373: D12269.id.diff
May 18 2024, 12:24 AM
Unknown Object (File)
May 3 2024, 7:33 AM
Unknown Object (File)
Apr 9 2024, 7:03 PM
Unknown Object (File)
Mar 17 2024, 12:22 AM
Unknown Object (File)
Feb 7 2024, 8:58 PM
Subscribers

Details

Summary

Ref T7731. For no particular reason, we currently put ruleID and rulePHID on HeraldEffect objects.

Pretty much all callers need the HeraldRule objects instead, and some go to great lengths to get them.

Just attach the Rule objects.

Test Plan

Will test thoroughly after next-ish changeset.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Attach HeraldRules to HeraldEffects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/herald/adapter/HeraldAdapter.php
1002

woot!

This revision is now accepted and ready to land.Apr 6 2015, 4:11 PM
This revision was automatically updated to reflect the committed changes.