Page MenuHomePhabricator

Herald queries correctly label Object Rules
ClosedPublic

Authored by epkugelmass on Apr 2 2015, 4:18 AM.

Details

Summary

Fixes T7730. Herald queries used to incorrectly label object rules as global rules. An object rule is now labeled as such.

Test Plan

Made a few rules and looked at the herald query page.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epkugelmass updated this revision to Diff 29442.Apr 2 2015, 4:18 AM
epkugelmass retitled this revision from to Herald queries correctly label Object Rules.
epkugelmass updated this object.
epkugelmass edited the test plan for this revision. (Show Details)
epkugelmass added a reviewer: epriestley.

Side note: What are your thoughts on by-lines in this results list?
Only the personal rules by by-lines (the rule author). Object and global rules do not get anything.
What do you think of having object rules say "Triggered by: #project | rREPO"?
Not precisely sure how to go about doing this given that array $handles is only loaded with the rule author PHID.

epriestley accepted this revision.Apr 2 2015, 12:00 PM
epriestley edited edge metadata.

I'd be open to various different approaches here, but I tend to think this is a good one. One consideration is that the object list might be very long, which would make it awkward to display here.

(Handles will get easier to use soon, after T7689.)

This revision is now accepted and ready to land.Apr 2 2015, 12:00 PM
This revision was automatically updated to reflect the committed changes.