Page MenuHomePhabricator

Remove all checks for untracked files from Arcanist
AbandonedPublic

Authored by epriestley on Apr 2 2015, 2:22 AM.

Details

Summary

Fixes T7521. See discussion in T7521#104969 about alternatives.

Test Plan
  • Created this revision in git with random junk in working copy.
  • If we proceed, I'll test it more carefully in hg and svn.

Diff Detail

Repository
rARC Arcanist
Branch
untrack1
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5095
Build 5113: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove all checks for untracked files from Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Specifically I don't think you should be so hastily removing this feature. I can see people upgrading Arcanist and getting tripped up because it's no longer telling them when they're about to do bad things (and that will be perceived as Arcanists fault for no longer telling them).

I am not sure that this behaviour should be removed. The behaviour of arc diff prior to D11843 appeared to be add untracked files using a prompt (admitedly separate to adding uncommitted files), which was changed to move a single prompt. I don't believe that leaving untracked files in the working copy is a desirable behaviour.

btrahan requested changes to this revision.Apr 2 2015, 7:57 PM
btrahan edited edge metadata.

I choose D12258 :D

This revision now requires changes to proceed.Apr 2 2015, 7:57 PM