Paths

Table of Contentst

Differential D12231

Remove all application-specific reply handler domains
ClosedPublic
Actions

Authored by epriestley on Mar 31 2015, 11:33 PM.

Tags

None

Referenced Files

	F13139141: D12231.diff
	Fri, May 3, 2:33 AM

	Unknown Object (File)
	Mon, Apr 29, 1:14 PM

	Unknown Object (File)
	Thu, Apr 11, 7:02 AM

	Unknown Object (File)
	Tue, Apr 9, 12:40 PM

	Unknown Object (File)
	Tue, Apr 9, 11:58 AM

	Unknown Object (File)
	Sun, Apr 7, 6:11 AM

	Unknown Object (File)
	Sun, Apr 7, 3:30 AM

	Unknown Object (File)
	Fri, Apr 5, 5:12 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7199: Expand the power of "!action" commands in email

Commits

Restricted Diffusion Commit
rPbad645f1ecdd: Remove all application-specific reply handler domains

Summary

Ref T7199. These were a bad idea which got copy-pasted a bunch.

There is zero reason to ever set these to different things.
Unsurprisingly, I don't know of any install which has them set to different things.

Unless I've completely forgotten about it, this option was not motivated by some obscure business need, it was just a bad decision which didn't catch anyone's attention at the time.

We partially remedied the mistake at some point by introducing metamta.reply-handler-domain, which works as a default for all applications, but never cleaned this mess up.

Test Plan

Sent some mail from applications, verified it picked up appropraite reply handler domains.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29382.Mar 31 2015, 11:33 PM

epriestley retitled this revision from to Remove all application-specific reply handler domains.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7199: Expand the power of "!action" commands in email.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 31 2015, 11:34 PM

Be slightly less aggressive about removing Macro config, it still has one option.

btrahan accepted this revision.Mar 31 2015, 11:38 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 11:38 PM

Closed by commit rPbad645f1ecdd: Remove all application-specific reply handler domains (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 11:48 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D12233: Remove all application-specific reply handler class overrides.Apr 1 2015, 12:01 AM

epriestley mentioned this in rP34db543d2774: Remove all application-specific reply handler class overrides.Apr 1 2015, 12:22 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

mail/

PhabricatorAuditReplyHandler.php

5 lines

config/

check/

PhabricatorExtraConfigSetupCheck.php

11 lines

option/

PhabricatorMetaMTAConfigOptions.php

4 lines

differential/

config/

PhabricatorDifferentialConfigOptions.php

7 lines

mail/

DifferentialReplyHandler.php

5 lines

diffusion/

config/

PhabricatorDiffusionConfigOptions.php

9 lines

macro/

config/

PhabricatorMacroConfigOptions.php

4 lines

mail/

PhabricatorMacroReplyHandler.php

5 lines

maniphest/

config/

PhabricatorManiphestConfigOptions.php

21 lines

mail/

ManiphestReplyHandler.php

5 lines

metamta/

replyhandler/

PhabricatorMailReplyHandler.php

16 lines

owners/

mail/

OwnersPackageReplyHandler.php

4 lines

pholio/

config/

PhabricatorPholioConfigOptions.php

6 lines

mail/

PholioReplyHandler.php

5 lines

repository/

mail/

PhabricatorRepositoryPushReplyHandler.php

4 lines

docs/

user/

configuration/

configuring_inbound_email.diviner

19 lines

Diff 29388

src/applications/audit/mail/PhabricatorAuditReplyHandler.php

Loading...

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

Loading...

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

Loading...

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

Loading...

src/applications/differential/mail/DifferentialReplyHandler.php

Loading...

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

Loading...

src/applications/macro/config/PhabricatorMacroConfigOptions.php

Loading...

src/applications/macro/mail/PhabricatorMacroReplyHandler.php

Loading...

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

Loading...

src/applications/maniphest/mail/ManiphestReplyHandler.php

Loading...

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...

src/applications/owners/mail/OwnersPackageReplyHandler.php

Loading...

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

Loading...

src/applications/pholio/mail/PholioReplyHandler.php

Loading...

src/applications/repository/mail/PhabricatorRepositoryPushReplyHandler.php

Loading...

src/docs/user/configuration/configuring_inbound_email.diviner

Loading...