Differential D12227

Conpherence - fix possible fatal
ClosedPublic
Actions

Authored by btrahan on Mar 31 2015, 8:55 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7671: Runtime Exception when showing dashboard w/ Conpherence panel

Commits

Restricted Diffusion Commit
rPe0acb75be9eb: Conpherence - fix possible fatal

Summary

if users have no conpherences I think this is possible? just init it with the rest of the variables we init when we have no conpherence and we should be good to go. fixes T7671.

Test Plan

logicypoo

Diff Detail

Repository

rP Phabricator

Branch

T7671

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5062
Build 5080: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29375.Mar 31 2015, 8:55 PM

btrahan added a task: T7671: Runtime Exception when showing dashboard w/ Conpherence panel.

btrahan retitled this revision from to Conpherence - fix possible fatal.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 31 2015, 8:55 PM

cspeckmim mentioned this in T7671: Runtime Exception when showing dashboard w/ Conpherence panel.Mar 31 2015, 8:58 PM

epriestley accepted this revision.Mar 31 2015, 8:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 8:59 PM

Closed by commit rPe0acb75be9eb: Conpherence - fix possible fatal (authored by btrahan, committed by btrahan). · Explain WhyMar 31 2015, 9:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceColumnViewController.php

10 lines

Diff 29375

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Conpherence - fix possible fatalClosedPublicActions