Conpherence - fix bad query from D12222
ClosedPublic
Actions

Authored by btrahan on Mar 31 2015, 8:01 PM.

Details

Reviewers

epriestley
chad

Commits

Restricted Diffusion Commit
rP3cb5cac018b2: Conpherence - fix bad query from D12222

Summary

D12222 did an evil thing. This correctly scopes this to just the threads you are participating in and not all threads which then get filtered from policy later, super slowly...

Test Plan

still 'works' and probably wont kill prod

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29369.Mar 31 2015, 8:01 PM

btrahan retitled this revision from to Conpherence - fix bad query from D12222.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 31 2015, 8:01 PM

epriestley accepted this revision.Mar 31 2015, 8:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 8:01 PM

We could maybe just put this in ConpherenceThreadQuery, e.g. always have a "viewer is participant or type is room" clause in the WHERE.

Closed by commit rP3cb5cac018b2: Conpherence - fix bad query from D12222 (authored by btrahan, committed by btrahan). · Explain WhyMar 31 2015, 8:02 PM

This revision was automatically updated to reflect the committed changes.

ACK - will do that in a diff coming soon.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadSearchEngine.php

4 lines

Diff 29370

View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Conpherence - fix bad query from D12222ClosedPublicActions