Page MenuHomePhabricator

Conpherence - refine menu interactions with respect to "Show More"
ClosedPublic

Authored by btrahan on Mar 31 2015, 7:31 PM.
Tags
None
Referenced Files
F13043221: D12222.diff
Wed, Apr 17, 2:27 PM
Unknown Object (File)
Tue, Apr 16, 12:45 PM
Unknown Object (File)
Tue, Apr 16, 12:45 PM
Unknown Object (File)
Tue, Apr 16, 12:45 PM
Unknown Object (File)
Tue, Apr 16, 12:39 PM
Unknown Object (File)
Tue, Apr 16, 12:06 PM
Unknown Object (File)
Thu, Apr 11, 6:58 AM
Unknown Object (File)
Thu, Apr 11, 6:55 AM
Subscribers

Details

Summary

Ref T7566. Prior to this diff, we had a broken mess in the "Messages" section. Now, "Messages" behave like rooms in that whatever is loaded at page load time is at the top of the list.

Additionally, refine "show more" behavior such that it simply shows the next X, but if there exists X + 1 then we have another "show more" that kicks you to application search. Theoretically, there are still corner cases where users are in a ton of rooms or a ton of messages respectively, but this feels pretty good.

Consolidates title rendering code so we always render the list of participants and no more "No Title".

Also remove the policy icons for messages consistently, helping to differentiate them from rooms at a glance.

Test Plan

clicked around in conpherence main - looked good. tried "show more" and it worked! played around in durable column and things seemed reasonable there too.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - refine menu interactions with respect to "Show More".
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
75–106

This file needs more work still. I think its okay-ish to stop here, knowing that's next?

Some self review I'll address shortly.

src/applications/conpherence/view/ConpherenceThreadListView.php
139

whoops, will fix

145

same

197–205

i'll move this a little lower since its only used in that block

webroot/rsrc/js/application/conpherence/behavior-menu.js
481

let @chad rejoice

webroot/rsrc/js/application/conpherence/behavior-menu.js
481

itsawesome

epriestley edited edge metadata.

FWIW, I like the thing just always being a link and never a disclosure action, but maybe there's a larger pool of "sometimes-used" threads/rooms than I anticipate.

The amount of red in this diff is v. nice.

This revision is now accepted and ready to land.Mar 31 2015, 7:43 PM
This revision was automatically updated to reflect the committed changes.

Yeah, I don't really know how people are going to use the thing, but pragmatically we're now pulling 1/4 the rows so that's not a bad start on that front at least. :D

roll secure and let's see this bad boy!

That "All Messages" query is bad sauce!