Page MenuHomePhabricator

Remove Controller->getHandle() and Controller->loadHandles()
ClosedPublic

Authored by epriestley on Mar 30 2015, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:12 AM
Unknown Object (File)
Sun, Mar 17, 8:40 PM
Unknown Object (File)
Sun, Mar 17, 6:48 PM
Unknown Object (File)
Sun, Mar 17, 6:14 PM
Unknown Object (File)
Sun, Mar 17, 6:13 PM
Unknown Object (File)
Fri, Mar 15, 4:14 PM
Unknown Object (File)
Fri, Mar 15, 4:10 PM
Unknown Object (File)
Feb 18 2024, 5:44 AM
Subscribers

Details

Summary

Ref T7689. Modernize all callsites of these methods.

Test Plan
  • Poked at dashboards.
    • Pretty sure this code is technically unreachable right now.
  • Viewed commit; viewed "Audit Status".
  • Viewed a fund; viewed "Payable to"; viewed "Owner".
  • Viewed herald rules; viewed "Author"; viewed "Applies To".
  • Viewed a Legalpad document; viewed "Contributors".
  • Viewed Phame post list; viewed blog; viewed post (viewed "Blog", viewed "Blogger").
  • Viewed a macro; viewed "Audio".
  • Viewed a Phriction page; viewed "Last Author".
  • Viewed a Ponder question; viewed "Author".
  • Viewed a Ponder answer; viewed header.
    • Behavior changed very slightly here; whatevs.
  • Viewed a Countdown; viewed "Author".

Diff Detail

Repository
rP Phabricator
Branch
param7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5041
Build 5059: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove Controller->getHandle() and Controller->loadHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.