Page MenuHomePhabricator

Remove most callsites to Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 7:46 PM
Unknown Object (File)
Fri, Apr 12, 1:06 PM
Unknown Object (File)
Tue, Apr 9, 11:35 PM
Unknown Object (File)
Mon, Apr 8, 12:21 AM
Unknown Object (File)
Fri, Mar 29, 3:23 AM
Unknown Object (File)
Mar 15 2024, 3:51 PM
Unknown Object (File)
Feb 3 2024, 2:46 AM
Unknown Object (File)
Jan 31 2024, 5:34 PM

Details

Summary

Ref T7689. This moves most of the easy/testable callsites off Controller->renderHandlesForPHIDs().

Test Plan
  • Viewed a file; viewed author; viewed "attached" tab.
  • Viewed a mock; viewed attached tasks.
  • Viewed a credential; viewed "Used By".
  • Viewed a paste; viewed author; viewed forks; viewed forked from.
  • Viewed a dashboard; viewed panel list.
  • Viewed a dashboard panel; viewed "Appears On".
  • Viewed a Phortune account; viewed "Members"; viewed payment methods.
  • Viewed a Phortune merchant account; viewed "Members".
  • Viewed Phortune account switcher; viewed "Accounts".
    • I just removed "Members:" here since it felt kind of out-of-place anyway.
  • Viewed a Phragment fragment, viewed "Latest Version", viewed "Snapshots".
  • Viewed a Phargment snapshot, viewed "Fragment".

Diff Detail

Repository
rP Phabricator
Branch
param4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5038
Build 5056: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove most callsites to Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.