Differential D12206

Fix an issue where redirects would work incorrectly in Quicksand
ClosedPublic
Actions

Authored by epriestley on Mar 30 2015, 1:37 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7061: Some UIs activate dialogs incorrectly when Quicksand is active

Commits

Restricted Diffusion Commit
rPa03527f44074: Fix an issue where redirects would work incorrectly in Quicksand

Summary

Ref T7061. Quicksand still needs an ajax-style response here.

Test Plan

Clicked a file detail page (this redirects) with column open, ended up in the right place.

Diff Detail

Repository

rP Phabricator

Branch

quick6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5037
Build 5055: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29329.Mar 30 2015, 1:37 PM

epriestley retitled this revision from to Fix an issue where redirects would work incorrectly in Quicksand.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7061: Some UIs activate dialogs incorrectly when Quicksand is active.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 30 2015, 1:37 PM

btrahan accepted this revision.Mar 30 2015, 8:01 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM

Closed by commit rPa03527f44074: Fix an issue where redirects would work incorrectly in Quicksand (authored by epriestley, committed by epriestley). · Explain WhyMar 30 2015, 8:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

2 lines

Diff 29329

View Options

src/applications/base/controller/PhabricatorController.php

Fix an issue where redirects would work incorrectly in QuicksandClosedPublicActions