Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 7:53 PM
Unknown Object (File)
Feb 3 2024, 8:28 AM
Unknown Object (File)
Feb 3 2024, 2:46 AM
Unknown Object (File)
Jan 31 2024, 6:43 PM
Unknown Object (File)
Dec 21 2023, 11:06 PM
Unknown Object (File)
Nov 30 2023, 3:35 AM
Unknown Object (File)
Nov 30 2023, 2:32 AM
Unknown Object (File)
Nov 16 2023, 3:53 AM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.