Page MenuHomePhabricator
Differential D12143

Test image
AbandonedPublic
Actions

Authored by epriestley on Mar 24 2015, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 11:07 PM
Unknown Object (File)
Thu, Nov 21, 2:05 AM
Unknown Object (File)
Mon, Nov 18, 10:40 AM
Unknown Object (File)
Thu, Nov 14, 8:47 PM
Unknown Object (File)
Sun, Nov 10, 2:08 AM
Unknown Object (File)
Wed, Nov 6, 1:16 PM
Unknown Object (File)
Oct 18 2024, 8:01 PM
Unknown Object (File)
Oct 11 2024, 10:25 PM
View All Files
Subscribers
btrahan
chad
epriestley
jhurwitz
joshuaspence

Details

Reviewers
None
Summary

yep

Test Plan

oh yeah

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4959
Build 4977: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29192.Mar 24 2015, 5:40 PM
epriestley retitled this revision from to Test image.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
Herald added a subscriber: epriestley. · View Herald TranscriptMar 24 2015, 5:40 PM
epriestley added inline comments.Mar 24 2015, 5:40 PM
partytime.jpg
1

This is a comment on an image.

chad added a subscriber: chad.Mar 24 2015, 5:41 PM
chad added inline comments.
partytime.jpg
1

epriestley marked an inline comment as done.Mar 24 2015, 5:44 PM

DONE!

btrahan added subscribers: jhurwitz, btrahan.Mar 24 2015, 6:09 PM

cc @jhurwitz - I took a note that this wasn't working for you guys, but we're able to do this here. Did I misunderstand you / make this up ? :D Thanks!

jhurwitz added a comment.Mar 24 2015, 7:58 PM

I stand corrected. (Is this new in the past couple months, and I just never noticed?)

Thanks!!

epriestley added a comment.Mar 24 2015, 7:59 PM

I don't believe this has changed recently, although it's vaguely possible that I fixed it by accident in connection with T1460.

joshuaspence added a subscriber: joshuaspence.Mar 24 2015, 10:24 PM
Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage() must be an instance of PhabricatorFile, null given, called in /core/lib/phabricator/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php on line 188 and defined

???

epriestley abandoned this revision.May 17 2015, 2:29 PM

Revision Contents
Changeset List

Diff 29192

View Options

partytime.jpg

Loading...
Phabricator · Built by Phacility