Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 1:23 AM
Unknown Object (File)
Tue, Mar 5, 8:00 AM
Unknown Object (File)
Feb 9 2024, 12:54 AM
Unknown Object (File)
Feb 5 2024, 9:18 AM
Unknown Object (File)
Feb 3 2024, 2:40 AM
Unknown Object (File)
Dec 24 2023, 5:28 PM
Unknown Object (File)
Dec 21 2023, 9:56 PM
Unknown Object (File)
Dec 20 2023, 8:29 PM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable