Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
F17670700: D12141.diff
Sun, Jul 13, 1:27 AM
Unknown Object (File)
Tue, Jul 1, 1:15 AM
Unknown Object (File)
Sun, Jun 29, 5:20 AM
Unknown Object (File)
Sat, Jun 28, 10:02 PM
Unknown Object (File)
Jun 1 2025, 7:19 PM
Unknown Object (File)
May 29 2025, 12:26 AM
Unknown Object (File)
May 27 2025, 11:19 PM
Unknown Object (File)
May 6 2025, 5:47 PM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Branch
highlight
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4956
Build 4974: [Placeholder Plan] Wait for 30 Seconds