Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
F19109887: D12141.diff
Tue, Dec 9, 4:45 AM
F19057868: D12141.id.diff
Nov 29 2025, 12:09 AM
F19050697: D12141.diff
Nov 27 2025, 9:04 PM
F19032137: D12141.id.diff
Nov 25 2025, 4:37 AM
F18829738: D12141.id.diff
Oct 25 2025, 12:40 AM
F18825410: D12141.diff
Oct 23 2025, 9:42 PM
F18738689: D12141.id29189.diff
Oct 1 2025, 4:36 PM
F18656023: D12141.diff
Sep 22 2025, 9:17 PM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable