Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
F15490854: D12141.diff
Fri, Apr 11, 9:06 PM
F15489715: D12141.id29196.diff
Fri, Apr 11, 11:38 AM
F15465494: D12141.id29196.diff
Wed, Apr 2, 7:32 PM
F15450715: D12141.id.diff
Fri, Mar 28, 5:18 PM
F15421336: D12141.id29189.diff
Fri, Mar 21, 10:43 PM
F15386267: D12141.diff
Mar 15 2025, 12:15 AM
F15376236: D12141.id29196.diff
Mar 13 2025, 2:18 AM
F15370076: D12141.diff
Mar 12 2025, 9:03 AM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable