Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
F14016482: D12141.id29196.diff
Mon, Nov 4, 9:54 AM
F14016481: D12141.id29189.diff
Mon, Nov 4, 9:54 AM
F14016480: D12141.id.diff
Mon, Nov 4, 9:54 AM
F14014347: D12141.diff
Sun, Nov 3, 2:01 AM
F14011797: D12141.diff
Fri, Nov 1, 5:16 AM
F14011471: D12141.id29196.diff
Fri, Nov 1, 1:57 AM
F13994131: D12141.id29189.diff
Wed, Oct 23, 4:03 AM
F13966851: D12141.id.diff
Oct 16 2024, 10:03 AM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable