Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
F15578198: D12141.id.diff
Tue, May 6, 5:47 PM
F15572584: D12141.diff
Mon, May 5, 4:42 PM
F15548987: D12141.id29189.diff
Sun, Apr 27, 3:13 AM
F15543684: D12141.id.diff
Sat, Apr 26, 12:18 AM
F15538810: D12141.diff
Thu, Apr 24, 9:41 PM
F15532920: D12141.id29196.diff
Wed, Apr 23, 5:38 PM
F15516496: D12141.diff
Fri, Apr 18, 7:12 PM
F15490854: D12141.diff
Fri, Apr 11, 9:06 PM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable