Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 24, 4:41 PM
Unknown Object (File)
Wed, Nov 9, 9:50 AM
Unknown Object (File)
Oct 28 2022, 10:52 PM
Unknown Object (File)
Oct 27 2022, 11:01 PM
Unknown Object (File)
Oct 27 2022, 6:10 PM
Unknown Object (File)
Sep 6 2022, 1:36 AM
Unknown Object (File)
Sep 3 2022, 11:02 PM
Unknown Object (File)
Aug 29 2022, 7:21 PM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable