Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 11:19 AM
Unknown Object (File)
Apr 10 2026, 5:51 PM
Unknown Object (File)
Mar 26 2026, 5:16 AM
Unknown Object (File)
Jan 29 2026, 7:08 PM
Unknown Object (File)
Jan 29 2026, 1:13 AM
Unknown Object (File)
Jan 21 2026, 4:21 AM
Unknown Object (File)
Jan 8 2026, 4:46 AM
Unknown Object (File)
Dec 9 2025, 4:45 AM
Subscribers

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Screen_Shot_2015-03-24_at_5.56.22_AM.png (1×1 px, 192 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable