Page MenuHomePhabricator

Don't syntax highlight codebase pattern search results
ClosedPublic

Authored by epriestley on Mar 24 2015, 12:59 PM.

Details

Summary

Ref T5644. Ref T7472. Currently, we highlight each line of pattern search results in Diffusion.

  • This is incredibly slow for non-PHP languages which need to shell out to Pygments.
  • A lot of this highlighting isn't very useful anyway, because it doesn't have any context.

Instead, try to highlight pattern matches but don't highlight the source itself.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Don't syntax highlight codebase pattern search results.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Mar 24 2015, 6:37 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 24 2015, 6:37 PM
This revision was automatically updated to reflect the committed changes.