Page MenuHomePhabricator
Differential D12135

Add a linter rule for unnecessary use of the `final` modifier
ClosedPublic
Actions

Authored by joshuaspence on Mar 23 2015, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 26 2025, 2:59 PM
Unknown Object (File)
Apr 3 2025, 10:24 AM
Unknown Object (File)
Mar 26 2025, 9:53 PM
Unknown Object (File)
Mar 26 2025, 12:03 AM
Unknown Object (File)
Mar 20 2025, 9:35 AM
Unknown Object (File)
Mar 17 2025, 11:14 PM
Unknown Object (File)
Mar 13 2025, 8:59 PM
Unknown Object (File)
Mar 10 2025, 5:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier
Summary

Ref T7409. This was based on rhttps://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29162.Mar 23 2015, 1:13 PM
joshuaspence retitled this revision from to Add a linter rule for unnecessary use of the `final` modifier.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 23 2015, 1:13 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Mar 23 2015, 1:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 1:14 PM
Closed by commit rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier (authored by joshuaspence, committed by joshuaspence). · Explain WhyMar 23 2015, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
289 lines
__tests__/
xhpast/
10 lines
8 lines

Diff 29181

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Loading...
Phabricator · Built by Phacility