Page MenuHomePhabricator
Differential D12135

Add a linter rule for unnecessary use of the `final` modifier
ClosedPublic
Actions

Authored by joshuaspence on Mar 23 2015, 1:13 PM.
Tags
None
Referenced Files
F19760369: D12135.id29181.diff
Wed, Feb 18, 3:56 PM
F19747625: D12135.id29162.diff
Sun, Feb 15, 6:45 PM
F19723504: D12135.id29181.diff
Fri, Feb 13, 10:17 AM
F19533761: D12135.id.diff
Jan 20 2026, 8:04 PM
F18878410: D12135.diff
Nov 6 2025, 5:14 PM
F18822078: D12135.id.diff
Oct 23 2025, 4:03 AM
F18781020: D12135.id29162.diff
Oct 12 2025, 9:03 PM
F18628695: D12135.diff
Sep 16 2025, 7:05 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier
Summary

Ref T7409. This was based on rhttps://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29162.Mar 23 2015, 1:13 PM
joshuaspence retitled this revision from to Add a linter rule for unnecessary use of the `final` modifier.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 23 2015, 1:13 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Mar 23 2015, 1:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 1:14 PM
Closed by commit rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier (authored by joshuaspence, committed by joshuaspence). · Explain WhyMar 23 2015, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
289 lines
__tests__/
xhpast/
10 lines
8 lines

Diff 29181

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Loading...
Phabricator · Built by Phacility