Page MenuHomePhabricator
Differential D12135

Add a linter rule for unnecessary use of the `final` modifier
ClosedPublic
Actions

Authored by joshuaspence on Mar 23 2015, 1:13 PM.
Tags
None
Referenced Files
F18110120: D12135.id29162.diff
Mon, Aug 11, 4:21 PM
F18097064: D12135.diff
Fri, Aug 8, 10:54 AM
F18084615: D12135.id29181.diff
Tue, Aug 5, 4:25 PM
F18057142: D12135.id29162.diff
Mon, Aug 4, 8:55 AM
F18053301: D12135.id.diff
Mon, Aug 4, 4:27 AM
F18043433: D12135.diff
Sun, Aug 3, 5:50 AM
F17834259: D12135.id29162.diff
Sat, Jul 26, 2:12 PM
F17824672: D12135.diff
Sat, Jul 26, 5:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7409: Implement PHPCS lints
Commits
rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier
Summary

Ref T7409. This was based on rhttps://github.com/squizlabs/PHP_CodeSniffer/blob/master/CodeSniffer/Standards/Generic/Sniffs/CodeAnalysis/UnnecessaryFinalModifierSniff.php.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29162.Mar 23 2015, 1:13 PM
joshuaspence retitled this revision from to Add a linter rule for unnecessary use of the `final` modifier.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 23 2015, 1:13 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Mar 23 2015, 1:14 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 1:14 PM
Closed by commit rARCe79032fec289: Add a linter rule for unnecessary use of the `final` modifier (authored by joshuaspence, committed by joshuaspence). · Explain WhyMar 23 2015, 8:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
289 lines
__tests__/
xhpast/
10 lines
8 lines

Diff 29181

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/decl-parens-hug-closing.lint-test

Loading...
View Options

src/lint/linter/__tests__/xhpast/unnecessary-final-modifier.lint-test

Loading...
Phabricator · Built by Phacility