Differential D12134

Fix a few edge cases for call-time pass-by-reference linting
ClosedPublic
Actions

Authored by joshuaspence on Mar 23 2015, 12:23 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8530cfcec1d7: Fix a few edge cases for call-time pass-by-reference linting

Summary

Fix a few false positives.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29160.Mar 23 2015, 12:23 PM

joshuaspence retitled this revision from to Fix a few edge cases for call-time pass-by-reference linting.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 23 2015, 12:23 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Mar 23 2015, 12:25 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 23 2015, 12:25 PM

Closed by commit rARC8530cfcec1d7: Fix a few edge cases for call-time pass-by-reference linting (authored by joshuaspence, committed by joshuaspence). · Explain WhyMar 23 2015, 12:39 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

2 lines

__tests__/

xhpast/

call-time-pass-by-reference.lint-test

3 lines

Diff 29161

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/call-time-pass-by-reference.lint-test

Fix a few edge cases for call-time pass-by-reference lintingClosedPublicActions