Fixes T7646.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7646: Hide disabled build plans on autocomplete when editing Herald rule
- Commits
- Restricted Diffusion Commit
rPb4d0de6b96d2: T7646: Fix buildplan ac on Herald.
Repeat steps described in T7646 and expect disabled build plans not displayed.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7646_harbormaster_ac
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4947 Build 4965: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Instead, we should call setClosed($description)on TypeaheadResult, passing a string like pht('Disabled'). See PhabricatorProjectDatasource for an example.
This will still allow these plans to be selected, but only if they are the only match for the input, and they will show the user that the plan is disabled.
Previously, when we just removed disabled plans from these typehaeads, we ran into a few issues:
- Users would know something existed but not understand why they couldn't select it, because they'd forget or not consider that the thing was closed/disabled/archived.
- Users would, for various reasons, occasionally want to select disabled values, and be unable to.
Flagging these results seems to have resolved both issues: the disabled/closed stuff stays out of the way normally, but if you're trying to get to it you still can.
Comment Actions
Previously, when we just removed disabled plans
Er, sorry, I mean when we previously removed disabled objects. Specifically, disabled users and archived projects were removed from some typeaheads before we implemented the setClosed() behavior, which caused the issues described above.