Page MenuHomePhabricator
Differential D12130

Lift inline comment state transactions into core (in Differential)
ClosedPublic
Actions

Authored by epriestley on Mar 22 2015, 1:38 PM.
Tags
None
Referenced Files
F15508152: D12130.diff
Wed, Apr 16, 2:25 AM
F15453194: D12130.id29156.diff
Sat, Mar 29, 10:04 AM
F15451221: D12130.id.diff
Fri, Mar 28, 8:50 PM
F15445048: D12130.diff
Thu, Mar 27, 12:21 PM
F15396507: D12130.id.diff
Mar 16 2025, 2:49 PM
F15390633: D12130.id29156.diff
Mar 15 2025, 6:23 AM
F15385423: D12130.id29187.diff
Mar 14 2025, 10:33 PM
Unknown Object (File)
Feb 16 2025, 11:02 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rPdd3afe2aa2ae: Lift inline comment state transactions into core (in Differential)
Summary

Ref T1460. Follows D12129 and reduces code duplication.

Test Plan

Changed inline state in Differential.

Diff Detail

Repository
rP Phabricator
Branch
uni42
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4944
Build 4962: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29156.Mar 22 2015, 1:38 PM
epriestley retitled this revision from to Lift inline comment state transactions into core (in Differential).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1460: Add "Done" link to an inline comment.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 22 2015, 1:38 PM
btrahan accepted this revision.Mar 23 2015, 5:25 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 5:25 PM
Closed by commit rPdd3afe2aa2ae: Lift inline comment state transactions into core (in Differential) (authored by epriestley, committed by epriestley). · Explain WhyMar 24 2015, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
51 lines
storage/
67 lines
transactions/
storage/
6 lines

Diff 29156

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility