Page MenuHomePhabricator

Lift inline state transactions into core (in Diffusion)
ClosedPublic

Authored by epriestley on Mar 22 2015, 1:29 PM.

Details

Summary

Ref T1460. Ref T6403. Replace Diffusion::INLINEDONE with Transactions::INLINESTATE and generalize things enough that we can lift it into core.

The next change will lift Differential's similar implementation into the core.

Also start implementing a fix for T6403, providing an alternate hook for optional builtin transactions.

Test Plan

Changed inline state in Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29155.Mar 22 2015, 1:29 PM
epriestley retitled this revision from to Lift inline state transactions into core (in Diffusion).
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan accepted this revision.Mar 23 2015, 5:23 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 23 2015, 5:23 PM