Fixes T7620. I don't fully understand exactly what's going on here, but we don't actually need to call flush().
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T7620: git unable to pull after upgrading to latest
- Commits
- Restricted Diffusion Commit
rPc7dc59f9c403: Don't call flush() when emitting responses
- Put timing code around the echo.
- Made a fake page that emitted a lot of data.
- Saw the echo block proportionate to data size under curl --limit-rate ....
- See T7620.
- Downloaded a large file, got a reasonable progress bar and no obvious memory use issues.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- sslflush
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4941 Build 4959: [Placeholder Plan] Wait for 30 Seconds